Fix flaky testAddColumnConcurrently Ignite test#16963
Merged
findepi merged 1 commit intotrinodb:masterfrom Apr 12, 2023
Merged
Conversation
ebyhr
approved these changes
Apr 11, 2023
Member
There was a problem hiding this comment.
nit: Remove a redundant empty line.
Error: src/test/java/io/trino/plugin/ignite/TestIgniteConnectorTest.java:[308] (regexp) RegexpMultiline: Multiple consecutive blank lines
Member
Author
My bad. I must have messed up something when doing things too quickly. |
findepi
deleted the
findepi/fix-flaky-testaddcolumnconcurrently-ignite-test-23e043
branch
findepi
restored the
findepi/fix-flaky-testaddcolumnconcurrently-ignite-test-23e043
branch
Member
Author
Hopefully fix `TestIgniteConnectorTest.testAddColumnConcurrently`. The fix hasn't been verified, as the test cannot be run on Apple M1.
findepi
force-pushed
the
findepi/fix-flaky-testaddcolumnconcurrently-ignite-test-23e043
branch
from
54ff6b4 to
1639548
Compare
findepi
deleted the
findepi/fix-flaky-testaddcolumnconcurrently-ignite-test-23e043
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #16980