Refactor test for ADD NON NULL column and change default expected behavior#16885
Merged
Refactor test for ADD NON NULL column and change default expected behavior#16885
Conversation
findepi
added
test
no-release-notes
findepi
force-pushed
the
findepi/add-non-null-test
branch
from
f04ad64 to
237ea21
Compare
findepi
changed the title
findepi
force-pushed
the
findepi/add-non-null-test
branch
2 times, most recently
from
5f2ff3b to
fb60700
Compare
findepi
force-pushed
the
findepi/add-non-null-test
branch
from
fb60700 to
e47bb4e
Compare
findepi
commented
Apr 5, 2023
| } | ||
|
|
||
| @Test | ||
| public void testAddNotNullColumn() |
Member
Author
There was a problem hiding this comment.
i intentionally didn't use testAddNotNullColumnToNonEmptyTable to help identity overrides which became redundant now that we changed what behavior we expect by default.
ebyhr
approved these changes
Apr 5, 2023
findepi
force-pushed
the
findepi/add-non-null-test
branch
from
e47bb4e to
32168bb
Compare
hashhar
approved these changes
Apr 11, 2023
Member
Author
findepi
force-pushed
the
findepi/add-non-null-test
branch
6 times, most recently
from
3eac870 to
c927843
Compare
Previously, when list has wrong length, their contents were not provided
in the failure message:
java.lang.AssertionError: lists don't have the same size expected [4] but found [5]
Separately test case when table is empty and when it is not. Also, change default expected behavior: adding a NON NULL column to a non-empty table should generally fail, since DEFAULT value was not provided.
findepi
force-pushed
the
findepi/add-non-null-test
branch
from
c927843 to
eefc7dd
Compare
Member
Author
|
CI #17033 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Separately test case when table is empty and when it is not.
Also, change default expected behavior: adding a NON NULL column to a
non-empty table should generally fail, since DEFAULT value was not
provided.