Skip to content

Fix flaky testAddColumnConcurrently Ignite test #16963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
findepi merged 1 commit into from
Apr 12, 2023
Merged

Fix flaky testAddColumnConcurrently Ignite test #16963

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions plugin/trino-ignite/src/test/java/io/trino/plugin/ignite/TestIgniteConnectorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -307,6 +307,12 @@ protected boolean isColumnNameRejected(Exception exception, String columnName, b
return errorMessage.contains("Failed to complete exchange process");
}

@Override
protected void verifyConcurrentAddColumnFailurePermissible(Exception e)
{
assertThat(e).hasMessage("Schema change operation failed: Thread got interrupted while trying to acquire table lock.");
}

@Override
public void testAddNotNullColumnToNonEmptyTable()
{
Expand Down