Skip to content

Pin version of jackson-dataformat-xml transitive deps #16912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ksobolew wants to merge 1 commit into from
Closed

Pin version of jackson-dataformat-xml transitive deps #16912

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1224,6 +1224,13 @@
<version>3.18.1</version>
</dependency>

<dependency>
<!-- pinned for transitive dependencies; TODO: move this to airbase -->
<groupId>com.fasterxml.jackson.dataformat</groupId>
<artifactId>jackson-dataformat-xml</artifactId>
Copy link
Copy Markdown
Member

@hashhar hashhar Apr 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need this for every new transitive dependency we pull? Does jackson provide a bom that we can import?

Copy link
Copy Markdown
Contributor Author

@ksobolew ksobolew Apr 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, they do! But I would consider this to be temporary and doing the proper solution in Airbase - I'll update airlift/airbase#346 to use it. Thanks for pointing this out!

<version>${dep.jackson.version}</version>
</dependency>

<dependency>
<groupId>com.github.ben-manes.caffeine</groupId>
<artifactId>caffeine</artifactId>
Expand Down