Conversation
There was a problem hiding this comment.
@findepi is this ok? Tried to reword the suggestion from the issue to avoid the double negative.
There was a problem hiding this comment.
what do we normally say for predicate pushdown
Add support for predicate pushdown for predicates with arithmetic expressions
maybe?
There was a problem hiding this comment.
Yeah, we usually do that, but I think this is actually a superior explanation to an end user. Probably how we should've been doing it this entire time? I read the proposed release note from @hashhar and personally thought, "yeah, that's an improvement over how we've historically done this."
There was a problem hiding this comment.
Fair enough .. I am happy to switch to this going forward
There was a problem hiding this comment.
actually this wording is what Piotr used in the very first complex pushdown release note and I liked it so copied from there.
There was a problem hiding this comment.
it's more wordy than what we usually use but I think conveys the improvement much better
There was a problem hiding this comment.
| * Add support for arithmetic binary expressions in table check constraints. ({issue}`16721`) | |
| * Add support for arithmetic binary expressions in table ``CHECK`` constraints. ({issue}`16721`) |
check is a syntax element.
There was a problem hiding this comment.
Either way is ok. In the SQL spec they are called "table check constraints"
045bd22 to
8719412
Compare
Description
Assemble the release notes for the upcoming Trino 412 release. Fixes #16798
Release notes
(x) This is not user-visible or docs only and no release notes are required.
Verification for each pull request
Format: maintainer, PR/issue number, ✅ / ❌ rn ✅ / ❌ docs
✅ rn - release note added and verified, or assessed to be not necessary, set to ❌ rn before completion
✅ docs - need for docs assessed and merged, or assessed to be not necessary, set to ❌ docs before completion
29 Mar 2023
migrateprocedure #16779 ✅ rn ✅ docsADD COLUMNin Ignite connector #16755 ✅ rn ✅ docsTestDeltaLakePerTransactionMetastoreCachewithCountingAccessHiveMetastore#16730 ✅ rn ✅ docs30 Mar 2023
31 Mar 2023
1 Apr 2023
2 Apr 2023
3 Apr 2023
oracle.remarks-reporting.enabledin connector test #16818 ✅ rn ✅ docsThe specified key does not existto FileNotFoundException #16703 ✅ rn ✅ docsassertExpressionmethod inTestSqlParser#16819 ✅ rn ✅ docsCREATE TABLE AS SELECTin Ignite type mapping #16423 ✅ rn ✅ docs4 Apr 2023
5 Apr 2023
testTableWithNonNullableColumnsto update NOT NULL column in Delta Lake connector #16883 ✅ rn ✅ docs