Skip to content

Rename method to use Trino terminology#16760

Merged
ebyhr merged 1 commit intotrinodb:masterfrom
wendigo:serafin/improve-method-name
Mar 30, 2023
Merged

Rename method to use Trino terminology#16760
ebyhr merged 1 commit intotrinodb:masterfrom
wendigo:serafin/improve-method-name

Conversation

@wendigo
Copy link
Copy Markdown
Contributor

@wendigo wendigo commented Mar 28, 2023

No release notes.

@cla-bot cla-bot bot added the cla-signed label Mar 28, 2023
Copy link
Copy Markdown
Member

@nineinchnick nineinchnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

100%

Copy link
Copy Markdown
Member

@ebyhr ebyhr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you change other two "TrinoMaster" usages in EnvironmentOptions & EnvironmentUp classes?

@wendigo wendigo force-pushed the serafin/improve-method-name branch from 07588f3 to c093918 Compare March 29, 2023 09:12
@wendigo
Copy link
Copy Markdown
Contributor Author

wendigo commented Mar 29, 2023

@ebyhr done

@ebyhr ebyhr added the no-release-notes This pull request does not require release notes entry label Mar 30, 2023
@ebyhr ebyhr merged commit 24850cf into trinodb:master Mar 30, 2023
@github-actions github-actions bot added this to the 412 milestone Mar 30, 2023
@wendigo wendigo deleted the serafin/improve-method-name branch January 21, 2025 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed no-release-notes This pull request does not require release notes entry

Development

Successfully merging this pull request may close these issues.

4 participants