Skip to content

Document avro.schema.literal property use for interpreting table data#16311

Merged
ebyhr merged 1 commit intotrinodb:masterfrom
Jessie212:jt/AvroSchemaLiteral-property
Apr 2, 2023
Merged

Document avro.schema.literal property use for interpreting table data#16311
ebyhr merged 1 commit intotrinodb:masterfrom
Jessie212:jt/AvroSchemaLiteral-property

Conversation

@Jessie212
Copy link
Copy Markdown
Contributor

Description

Document avro.schema.literal property use for interpreting table data

Additional context and related issues

#14426

Release notes

(x) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text:

# Section
* Fix some things. ({issue}`issuenumber`)

@cla-bot cla-bot bot added the cla-signed label Feb 28, 2023
@Jessie212 Jessie212 requested review from colebow and mosabua February 28, 2023 18:05
@mosabua
Copy link
Copy Markdown
Member

mosabua commented Feb 28, 2023

Lets put this on hold until the PR from @m57lyra is merged and then rebase and put it into the correct location.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is wrong

avro.schema.literal table property

I think this is a catalog configuration property

and the _ version is either a table property or a session property

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

avro.schema.literal -> avro_schema_literal

However this paragraph is mostly about avro_schema_url and how to eventually retrieve the avro schema of the table.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mosabua avro.schema.literal and avro.schema.url are Hive specific table properties.

@mosabua
Copy link
Copy Markdown
Member

mosabua commented Feb 28, 2023

Maybe @colebow or @findinpath can clarify the technical aspects..

@github-actions github-actions bot added the docs label Feb 28, 2023
@m57lyra
Copy link
Copy Markdown
Contributor

m57lyra commented Mar 1, 2023

It is merged @mosabua as of today. Good to go!

@Jessie212 Jessie212 force-pushed the jt/AvroSchemaLiteral-property branch 2 times, most recently from 77f90aa to 1ee27a0 Compare March 1, 2023 17:11
@Jessie212 Jessie212 force-pushed the jt/AvroSchemaLiteral-property branch from 1ee27a0 to 180f43f Compare March 14, 2023 22:30
@Jessie212 Jessie212 force-pushed the jt/AvroSchemaLiteral-property branch 2 times, most recently from a969edb to 0440407 Compare March 17, 2023 17:11
@Jessie212 Jessie212 force-pushed the jt/AvroSchemaLiteral-property branch from 0440407 to 03193ce Compare March 20, 2023 17:43
Copy link
Copy Markdown
Member

@mosabua mosabua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@mosabua mosabua requested a review from ebyhr March 31, 2023 23:30
@mosabua
Copy link
Copy Markdown
Member

mosabua commented Mar 31, 2023

Could @ebyhr @hashhar or @findepi review and merge please

@ebyhr ebyhr merged commit f10a667 into trinodb:master Apr 2, 2023
@github-actions github-actions bot added this to the 412 milestone Apr 2, 2023
@Jessie212 Jessie212 deleted the jt/AvroSchemaLiteral-property branch April 3, 2023 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

5 participants