Adjust the drop table logic for Delta Lake managed tables#15880
Adjust the drop table logic for Delta Lake managed tables#15880ebyhr merged 1 commit intotrinodb:masterfrom
Conversation
ebyhr
left a comment
There was a problem hiding this comment.
Could you rename the argument in TestDeltaLakeSplitManager.dropTable method as well?
There was a problem hiding this comment.
nit: How about renaming to deleteData? We need to guess the behavior from managedTable, but we can easily understand the behavior form deleteData.
bbeb664 to
0d8691a
Compare
|
/test-with-secrets sha=0d8691a8d20e66144e90961587c2520df73170c6 |
|
Stumbled on Seems to be caused by left-over stuff from 920d14c I see that there's already a PR for this. |
|
The CI workflow run with tests that require additional secrets finished as failure: https://github.com/trinodb/trino/actions/runs/4051475639 |
|
@ebyhr can you pls trigger again a build with secrets? |
|
/test-with-secrets sha=0d8691a8d20e66144e90961587c2520df73170c6 |
|
All Databricks product tests succeeded in https://github.com/trinodb/trino/actions/runs/4054233976/jobs/6975812918. Let me merge now. |
Description
Advise the metastore to delete table data only when dealing with managed tables.
Additional context and related issues
Delta Lake same as Hive works with
MANAGEDandEXTERNALtable types. In case of dealing withMANAGEDtables, the engine is responsible (either through delegating internally this responsibility to the metastore - HMS or doing this operation itself in case of AWS) to remove the content of the table when executingDROP TABLE table_namestatements.Release notes
(x) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text: