Add support for unregister_table procedure in Delta Lake#15856
Merged
Conversation
ebyhr
force-pushed
the
ebi/delta-unregister-table
branch
from
1ead9d3 to
a040c80
Compare
ebyhr
force-pushed
the
ebi/delta-unregister-table
branch
3 times, most recently
from
b38dfe3 to
dd5115b
Compare
findinpath
reviewed
Jan 27, 2023
ebyhr
force-pushed
the
ebi/delta-unregister-table
branch
from
dd5115b to
1bdb70b
Compare
findinpath
approved these changes
Jan 27, 2023
...src/main/java/io/trino/plugin/deltalake/metastore/HiveMetastoreBackedDeltaLakeMetastore.java
Outdated
Show resolved
Hide resolved
pajaks
reviewed
Jan 30, 2023
...rino-delta-lake/src/test/java/io/trino/plugin/deltalake/BaseDeltaLakeConnectorSmokeTest.java
Outdated
Show resolved
Hide resolved
...ta-lake/src/test/java/io/trino/plugin/deltalake/BaseDeltaLakeRegisterTableProcedureTest.java
Outdated
Show resolved
Hide resolved
alexjo2144
reviewed
Jan 30, 2023
Member
There was a problem hiding this comment.
Is null safe here, or do we need the context?
Member
Author
There was a problem hiding this comment.
The argument must be null if I understand correctly.
- https://github.com/trinodb/trino/blob/2fea3d5/core/trino-main/src/main/java/io/trino/execution/CallTask.java#L199-L201
- https://github.com/trinodb/trino/blob/bdd1cb5/core/trino-main/src/main/java/io/trino/security/InjectedConnectorAccessControl.java#L118-L123
Member
There was a problem hiding this comment.
Gotcha, that's exactly what I was looking for. Thanks
ebyhr
force-pushed
the
ebi/delta-unregister-table
branch
from
1bdb70b to
2fb547a
Compare
alexjo2144
approved these changes
Jan 31, 2023
ebyhr
force-pushed
the
ebi/delta-unregister-table
branch
2 times, most recently
from
f560c51 to
62833fa
Compare
findinpath
approved these changes
Feb 2, 2023
findepi
approved these changes
Feb 2, 2023
findinpath
reviewed
Feb 2, 2023
...-tests/src/main/java/io/trino/tests/product/deltalake/TestHiveAndDeltaLakeCompatibility.java
Outdated
Show resolved
Hide resolved
ebyhr
force-pushed
the
ebi/delta-unregister-table
branch
from
62833fa to
8bc0659
Compare
findinpath
approved these changes
Feb 3, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Relates to #15784
Release notes
(x) Release notes are required, with the following suggested text: