Skip to content

Adjust the drop table logic for Delta Lake managed tables #15880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ebyhr merged 1 commit into from
Jan 31, 2023
Merged

Adjust the drop table logic for Delta Lake managed tables #15880

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion plugin/trino-delta-lake/src/main/java/io/trino/plugin/deltalake/DeltaLakeMetadata.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1812,7 +1812,7 @@ public void dropTable(ConnectorSession session, ConnectorTableHandle tableHandle
Table table = metastore.getTable(handle.getSchemaName(), handle.getTableName())
.orElseThrow(() -> new TableNotFoundException(handle.getSchemaTableName()));

metastore.dropTable(session, handle.getSchemaName(), handle.getTableName(), table.getTableType().equals(EXTERNAL_TABLE.toString()));
metastore.dropTable(session, handle.getSchemaName(), handle.getTableName(), table.getTableType().equals(MANAGED_TABLE.toString()));
}

@Override
Expand Down
2 changes: 1 addition & 1 deletion ...rino-delta-lake/src/main/java/io/trino/plugin/deltalake/metastore/DeltaLakeMetastore.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ public interface DeltaLakeMetastore

void createTable(ConnectorSession session, Table table, PrincipalPrivileges principalPrivileges);

void dropTable(ConnectorSession session, String databaseName, String tableName, boolean externalTable);
void dropTable(ConnectorSession session, String databaseName, String tableName, boolean deleteData);

void renameTable(ConnectorSession session, SchemaTableName from, SchemaTableName to);

Expand Down
6 changes: 3 additions & 3 deletions .../main/java/io/trino/plugin/deltalake/metastore/HiveMetastoreBackedDeltaLakeMetastore.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,13 +166,13 @@ public void createTable(ConnectorSession session, Table table, PrincipalPrivileg
}

@Override
public void dropTable(ConnectorSession session, String databaseName, String tableName, boolean externalTable)
public void dropTable(ConnectorSession session, String databaseName, String tableName, boolean deleteData)
{
String tableLocation = getTableLocation(new SchemaTableName(databaseName, tableName), session);
delegate.dropTable(databaseName, tableName, true);
delegate.dropTable(databaseName, tableName, deleteData);
statisticsAccess.invalidateCache(tableLocation);
transactionLogAccess.invalidateCaches(tableLocation);
if (!externalTable) {
if (deleteData) {
try {
fileSystemFactory.create(session).deleteDirectory(tableLocation);
}
Expand Down
2 changes: 1 addition & 1 deletion ...n/trino-delta-lake/src/test/java/io/trino/plugin/deltalake/TestDeltaLakeSplitManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,7 +261,7 @@ public void createTable(ConnectorSession session, Table table, PrincipalPrivileg
}

@Override
public void dropTable(ConnectorSession session, String databaseName, String tableName, boolean externalTable)
public void dropTable(ConnectorSession session, String databaseName, String tableName, boolean deleteData)
{
throw new UnsupportedOperationException("Unimplemented");
}
Expand Down