Skip to content

Update testing Spark Iceberg docker image name#14569

Closed
alexjo2144 wants to merge 3 commits intotrinodb:masterfrom
alexjo2144:iceberg/docker-image-name
Closed

Update testing Spark Iceberg docker image name#14569
alexjo2144 wants to merge 3 commits intotrinodb:masterfrom
alexjo2144:iceberg/docker-image-name

Conversation

@alexjo2144
Copy link
Copy Markdown
Member

Description

Follow up from: trinodb/docker-images#148

Update Spark Iceberg image name.

Release notes

(x) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text:

@cla-bot cla-bot bot added the cla-signed label Oct 11, 2022
@alexjo2144 alexjo2144 requested a review from hashhar October 11, 2022 13:29
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should require a new release, right? If so, it is blocked because the JDK in Pheonix images was updated to an incompatible version, see #13733

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a PR open there that fixes it: trinodb/docker-images#143

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, you're right. Making this PR a draft until that release goes through

@alexjo2144 alexjo2144 marked this pull request as draft October 11, 2022 14:34
@ebyhr
Copy link
Copy Markdown
Member

ebyhr commented Oct 26, 2022

We released version 69 one week ago. Could you update this PR?

@alexjo2144 alexjo2144 force-pushed the iceberg/docker-image-name branch from 54cb76e to d9976b1 Compare October 26, 2022 18:35
@alexjo2144 alexjo2144 marked this pull request as ready for review October 26, 2022 18:35
@alexjo2144
Copy link
Copy Markdown
Member Author

@ebyhr thanks for the reminder. Made this a non-draft and included a commit bumping us to v 69

@hashhar
Copy link
Copy Markdown
Member

hashhar commented Nov 1, 2022

Superseded by #14810

@hashhar hashhar closed this Nov 1, 2022
@alexjo2144 alexjo2144 deleted the iceberg/docker-image-name branch November 3, 2022 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

4 participants