Merged
Conversation
Having the minor version in the image name is not helpful and has been out of date for some time.
findepi
approved these changes
Oct 5, 2022
Member
|
@hashhar ptal wrt release process |
ebyhr
approved these changes
Oct 5, 2022
Member
|
@alexjo2144 Why would you want to remove the old image? |
hashhar
approved these changes
Oct 6, 2022
Member
hashhar
left a comment
hashhar
left a comment
There was a problem hiding this comment.
LGTM.
Since this is entirely "new" image name release shouldn't need any manual actions.
Member
Author
I guess I'd find it messy/confusing to have around, but If you'd rather leave it I'm fine with that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Having the minor version in the image name is not helpful and has been out of date for some time.
@findepi after deploying this are you planning on removing the old image? I could try adding code to the automation to do it programmatically but it's probably easier for you to just do it manually.
#123 (comment)