Skip to content

Update testing Spark Iceberg docker image name #14569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
alexjo2144 wants to merge 3 commits into from
Closed

Update testing Spark Iceberg docker image name #14569

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8f13eba
Update docker images to version 69
alexjo2144 Oct 26, 2022
d9976b1
Update testing Spark Iceberg docker image name
Oct 5, 2022
2620cf8
empty
ebyhr Oct 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@
<dep.iceberg.version>1.0.0</dep.iceberg.version>
<dep.spotbugs-annotations.version>4.7.2</dep.spotbugs-annotations.version>

<dep.docker.images.version>65</dep.docker.images.version>
<dep.docker.images.version>69</dep.docker.images.version>

<!--
America/Bahia_Banderas has:
Expand Down
2 changes: 1 addition & 1 deletion ...src/main/java/io/trino/tests/product/launcher/env/environment/EnvSinglenodeSparkHive.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ public void extendEnvironment(Environment.Builder builder)
private DockerContainer createSpark()
{
// TODO: Switch to pure Spark 3 image once it's available (https://github.com/trinodb/trino/issues/7063)
DockerContainer container = new DockerContainer("ghcr.io/trinodb/testing/spark3.0-iceberg:" + hadoopImagesVersion, "spark")
DockerContainer container = new DockerContainer("ghcr.io/trinodb/testing/spark3-iceberg:" + hadoopImagesVersion, "spark")
Copy link
Copy Markdown
Member

@nineinchnick nineinchnick Oct 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should require a new release, right? If so, it is blocked because the JDK in Pheonix images was updated to an incompatible version, see #13733

Copy link
Copy Markdown
Member

@nineinchnick nineinchnick Oct 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a PR open there that fixes it: trinodb/docker-images#143

Copy link
Copy Markdown
Member Author

@alexjo2144 alexjo2144 Oct 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, you're right. Making this PR a draft until that release goes through

.withEnv("HADOOP_USER_NAME", "hive")
.withCopyFileToContainer(
forHostPath(dockerFiles.getDockerFilesHostPath("conf/environment/singlenode-spark-hive/spark-defaults.conf")),
Expand Down
2 changes: 1 addition & 1 deletion .../main/java/io/trino/tests/product/launcher/env/environment/EnvSinglenodeSparkIceberg.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ public void extendEnvironment(Environment.Builder builder)
@SuppressWarnings("resource")
private DockerContainer createSpark()
{
DockerContainer container = new DockerContainer("ghcr.io/trinodb/testing/spark3.0-iceberg:" + hadoopImagesVersion, "spark")
DockerContainer container = new DockerContainer("ghcr.io/trinodb/testing/spark3-iceberg:" + hadoopImagesVersion, "spark")
.withEnv("HADOOP_USER_NAME", "hive")
.withCopyFileToContainer(
forHostPath(dockerFiles.getDockerFilesHostPath("conf/environment/singlenode-spark-iceberg/spark-defaults.conf")),
Expand Down