Use AllowDeltaLakeManagedTableRename in DeltaLakeMetadata#14066
Merged
findepi merged 1 commit intotrinodb:masterfrom Sep 13, 2022
Merged
Use AllowDeltaLakeManagedTableRename in DeltaLakeMetadata#14066findepi merged 1 commit intotrinodb:masterfrom
findepi merged 1 commit intotrinodb:masterfrom
Conversation
homar
force-pushed
the
homar/use_allow_rename_in_deltalake
branch
from
e0c0217 to
6cedeb9
Compare
findepi
reviewed
Sep 9, 2022
Member
There was a problem hiding this comment.
in #14059 i went with "with current metastore configuration" to indicate this isn't a permanent Delta's property, but it's configuration dependent.
Not sure if it matters though
Member
|
Thank you for your PR! I had a bug in #14059. You'll need to rebase. |
homar
force-pushed
the
homar/use_allow_rename_in_deltalake
branch
4 times, most recently
from
d35e5a3 to
fd52530
Compare
homar
added
the
no-release-notes
Member
please update the commit and PR titles |
Previously MetastoreTypeConfig was passed to DeltaLakeMetadata and based on the type of the metastore which was represented as string the runtime decision was made if table can be renamed or not. This commit introduces a guice binded instance of boolean named AllowDeltaLakeManagedTableRename which value is set based on the used metastore type and which will be used to make a runtime decision if table can be renamed
homar
force-pushed
the
homar/use_allow_rename_in_deltalake
branch
from
fd52530 to
88e7514
Compare
homar
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Similar approach to what was done #14059 seems cleaner than the current one
Release notes
(x) This is not user-visible and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text: