Unbind MetastoreTypeConfig in Hive tests#14059
Conversation
e6d860b to
3ff201a
Compare
|
I am ashamed I haven't done it in the first place. |
|
Just a thought if you did it for hive, maybe it would make sense to do it the same way for DeltaLake as well ? |
ksobolew
left a comment
There was a problem hiding this comment.
Thanks! (Sorry if I communicated the problem with this binding in a not great way)
3ff201a to
a0d2e9c
Compare
@homar do you have a pointer to the code you'd want to see changed? |
I will try to do it |
|
sorry I missclicked, I didn't mean to close the PR ;/ |
a0d2e9c to
5ab2970
Compare
plugin/trino-hive/src/main/java/io/trino/plugin/hive/AllowTableRename.java
Outdated
Show resolved
Hide resolved
This removes `MetastoreTypeConfig` binding added in 7229738 and replaces it with an annotated boolean, decoupling the `HiveMetadata` logic from metastore implementations.
5ab2970 to
f68dbbf
Compare
|
CI #13889 |
This removes
MetastoreTypeConfigbinding added infindepi@7229738 (#13707) and replaces it with an
annotated boolean, decoupling the
HiveMetadatalogic from metastoreimplementations.