Add redirection awareness for MERGE#14055
Conversation
There was a problem hiding this comment.
nit: you can put ON on the previous like, just like you would usually do with a JOIN
There was a problem hiding this comment.
i see it didn't, but we have a rule that disallows whitespace before ), right?
There was a problem hiding this comment.
I think you are hinting at airlift/airbase#323
I can convert the text block to a string concat construct.
There was a problem hiding this comment.
I think you are hinting at airlift/airbase#323
no
I can convert the text block to a string concat construct.
no need to.
the )) should be on the previous line though
f68bb4c to
2ebb18c
Compare
core/trino-main/src/main/java/io/trino/sql/analyzer/StatementAnalyzer.java
Outdated
Show resolved
Hide resolved
|
CI failure on |
...no-product-tests/src/main/java/io/trino/tests/product/hive/TestHiveRedirectionToIceberg.java
Outdated
Show resolved
Hide resolved
6970018 to
71cb948
Compare
71cb948 to
99c3ae0
Compare
99c3ae0 to
67be5a2
Compare
phd3
left a comment
There was a problem hiding this comment.
#14055 (comment) seems unaddressed, but lgtm. will merge if @findepi doesn't feel too strongly.
|
i don't feel strongly about that one, thank you @phd3 |
|
Merged, thanks! |
Description
Add redirection awareness for the task:
This is a fix.
This is a core engine change affecting mainly hive/iceberg connectors.
In the context of dealing with a shared Hive Metastore Service where tables of different types can co-exist in the metastore, it is helpful for the end-user to perform automatically table redirections when the user is in the context of a hive schema, but is referencing an iceberg table.
Related issues, pull requests, and links
Documentation
(x) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
( ) No release notes entries required.
(x) Release notes entries required with the following suggested text: