Skip to content

Add redirection awareness for MERGE #14055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
phd3 merged 2 commits into from
Sep 13, 2022
Merged

Add redirection awareness for MERGE #14055

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ab9bc83
Use `isView` to check if the table name corresponds to a view
findinpath Sep 12, 2022
67be5a2
Add redirection awareness for MERGE
findinpath Sep 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions core/trino-main/src/main/java/io/trino/sql/analyzer/StatementAnalyzer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2798,15 +2798,17 @@ protected Scope visitMerge(Merge merge, Optional<Scope> scope)
{
Relation relation = merge.getTarget();
Table table = getMergeTargetTable(relation);
QualifiedObjectName tableName = createQualifiedObjectName(session, table, table.getName());
if (metadata.isMaterializedView(session, tableName)) {
QualifiedObjectName originalTableName = createQualifiedObjectName(session, table, table.getName());
if (metadata.isMaterializedView(session, originalTableName)) {
throw semanticException(NOT_SUPPORTED, merge, "Merging into materialized views is not supported");
}
if (metadata.getView(session, tableName).isPresent()) {
if (metadata.isView(session, originalTableName)) {
throw semanticException(NOT_SUPPORTED, merge, "Merging into views is not supported");
}

TableHandle targetTableHandle = metadata.getTableHandle(session, tableName)
RedirectionAwareTableHandle redirection = metadata.getRedirectionAwareTableHandle(session, originalTableName);
QualifiedObjectName tableName = redirection.getRedirectedTableName().orElse(originalTableName);
TableHandle targetTableHandle = redirection.getTableHandle()
.orElseThrow(() -> semanticException(TABLE_NOT_FOUND, table, "Table '%s' does not exist", tableName));

StatementAnalyzer analyzer = statementAnalyzerFactory
Expand Down
27 changes: 27 additions & 0 deletions ...product-tests/src/main/java/io/trino/tests/product/hive/TestHiveRedirectionToIceberg.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,6 +224,33 @@ public void testUpdate()
onTrino().executeQuery("DROP TABLE " + icebergTableName);
}

@Test(groups = {HIVE_ICEBERG_REDIRECTIONS, PROFILE_SPECIFIC_TESTS})
public void testMerge()
{
String sourceTableName = "iceberg_merge_source_" + randomTableSuffix();
String targetTableName = "iceberg_merge_target_" + randomTableSuffix();
String hiveSourceTableName = "hive.default." + sourceTableName;
String hiveTargetTableName = "hive.default." + targetTableName;
String icebergSourceTableName = "iceberg.default." + sourceTableName;
String icebergTargetTableName = "iceberg.default." + targetTableName;

createIcebergTable(icebergSourceTableName, true, true);
createIcebergTable(icebergTargetTableName, true, false);

assertThat(onTrino().executeQuery("" +
"MERGE INTO " + hiveTargetTableName + " t USING " + hiveSourceTableName + " s ON t.nationkey = s.nationkey " +
"WHEN NOT MATCHED " +
" THEN INSERT (nationkey, name, regionkey, comment) " +
" VALUES (s.nationkey, s.name, s.regionkey, s.comment)"))
.updatedRowsCountIsEqualTo(25);
assertResultsEqual(
onTrino().executeQuery("TABLE " + icebergSourceTableName),
onTrino().executeQuery("TABLE " + icebergTargetTableName));

onTrino().executeQuery("DROP TABLE " + icebergSourceTableName);
onTrino().executeQuery("DROP TABLE " + icebergTargetTableName);
}

@Test(groups = {HIVE_ICEBERG_REDIRECTIONS, PROFILE_SPECIFIC_TESTS})
public void testDropTable()
{
Expand Down