Skip to content

Disable testGetPartitionsWithFilter test in Alluxio#13252

Merged
ebyhr merged 1 commit intotrinodb:masterfrom
ebyhr:ebi/hive-alluxio-disable
Jul 20, 2022
Merged

Disable testGetPartitionsWithFilter test in Alluxio#13252
ebyhr merged 1 commit intotrinodb:masterfrom
ebyhr:ebi/hive-alluxio-disable

Conversation

@ebyhr
Copy link
Copy Markdown
Member

@ebyhr ebyhr commented Jul 20, 2022

Description

Disable testGetPartitionsWithFilter test in Alluxio

Documentation

(x) No documentation is needed.

Release notes

(x) No release notes entries required.

The test fails with
```
Expecting ArrayList:
  <["p_string=__HIVE_DEFAULT_PARTITION__/p_integer=__HIVE_DEFAULT_PARTITION__",
    "p_string=abc/p_integer=123",
    "p_string=def/p_integer=456"]>
to contain only:
  <["p_string=abc/p_integer=123"]>
but the following element(s) were unexpected:
  <["p_string=__HIVE_DEFAULT_PARTITION__/p_integer=__HIVE_DEFAULT_PARTITION__",
    "p_string=def/p_integer=456"]>
	at io.trino.plugin.hive.AbstractTestHive.testGetPartitionsWithFilter(AbstractTestHive.java:1150)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:568)
	at org.testng.internal.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:104)
	at org.testng.internal.Invoker.invokeMethod(Invoker.java:645)
	at org.testng.internal.Invoker.invokeTestMethod(Invoker.java:851)
	at org.testng.internal.Invoker.invokeTestMethods(Invoker.java:1177)
	at org.testng.internal.TestMethodWorker.invokeTestMethods(TestMethodWorker.java:129)
	at org.testng.internal.TestMethodWorker.run(TestMethodWorker.java:112)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
	at java.base/java.lang.Thread.run(Thread.java:833)
```
@ebyhr ebyhr force-pushed the ebi/hive-alluxio-disable branch from 65febf8 to 31007d7 Compare July 20, 2022 09:55
@ebyhr ebyhr requested a review from findepi July 20, 2022 10:20
@Override
public void testGetPartitionsWithFilter()
{
// Alluxio metastore returns incorrect results
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

woah.
is it sometimes or always? (#13122 didn't have alluxio failures, right)

if Alluxio metastore is not correct, maybe we should disable that integration by default
and require some flag to enable it.
or add some docs entry cc @mosabua

Copy link
Copy Markdown
Member Author

@ebyhr ebyhr Jul 20, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's always as far as I confirmed. CI was green (https://github.com/trinodb/trino/runs/7422392334) in #13122, but I suppose it didn't run any tests somehow. cc: @nineinchnick

+ . plugin/trino-hive-hadoop2/bin/common.sh
++ SCRIPT_DIR=plugin/trino-hive-hadoop2/bin
++ INTEGRATION_TESTS_ROOT=plugin/trino-hive-hadoop2/bin/..
++ PROJECT_ROOT=plugin/trino-hive-hadoop2/bin/../../..
++ DOCKER_COMPOSE_LOCATION=plugin/trino-hive-hadoop2/bin/../conf/docker-compose.yml
++ source plugin/trino-hive-hadoop2/bin/../conf/hive-tests-defaults.sh
++++ ./mvnw help:evaluate -Dexpression=dep.docker.images.version -q -DforceStdout
+++ DEFAULT_DOCKER_VERSION=64
+++ '[' -z 64 ']'
+++ export DOCKER_IMAGES_VERSION=64
+++ DOCKER_IMAGES_VERSION=64
+++ export HADOOP_BASE_IMAGE=ghcr.io/trinodb/testing/hdp2.6-hive
+++ HADOOP_BASE_IMAGE=ghcr.io/trinodb/testing/hdp2.6-hive
++ docker-compose version
docker-compose version 1.29.2, build 5becea4c
docker-py version: 5.0.0
CPython version: 3.7.10
OpenSSL version: OpenSSL 1.1.0l  10 Sep 2019
++ docker version
Client:
 Version:           20.10.[17](https://github.com/trinodb/trino/runs/7422392334?check_suite_focus=true#step:14:18)+azure-1
 API version:       1.41
 Go version:        go1.17.11
 Git commit:        100c70[18](https://github.com/trinodb/trino/runs/7422392334?check_suite_focus=true#step:14:19)0fde3601def79a59cc3e996aa553c9b9
 Built:             Mon Jun  6 21:36:39 UTC 2022
 OS/Arch:           linux/amd64
 Context:           default
 Experimental:      true
Server:
 Engine:
  Version:          20.10.17+azure-1
  API version:      1.41 (minimum version 1.12)
  Go version:       go1.17.11
  Git commit:       a89b84221c8560e7a3dee2a653353429e7628424
  Built:            Mon Jun  6 22:32:38 2022
  OS/Arch:          linux/amd64
  Experimental:     false
 containerd:
  Version:          1.5.13+azure-1
  GitCommit:        a17ec496a95e55601607ca50828147e8ccaeebf1
 runc:
  Version:          1.0.3
  GitCommit:        f46b6ba2c9314cfc8caae24a32ec5fe9ef1059fe
 docker-init:
  Version:          0.[19](https://github.com/trinodb/trino/runs/7422392334?check_suite_focus=true#step:14:20).0
  GitCommit:        
++ '[' -n '' ']'
++ PROXY=1[27](https://github.com/trinodb/trino/runs/7422392334?check_suite_focus=true#step:14:28).0.0.1
+ abort_if_not_gib_impacted
+ local module=plugin/trino-hive-hadoop2
+ local impacted_log=gib-impacted.log
+ '[' -f gib-impacted.log ']'
+ grep -q '^plugin/trino-hive-hadoop2$' gib-impacted.log
+ echo 'Module plugin/trino-hive-hadoop2 not present in gib-impacted.log, exiting'
Module plugin/trino-hive-hadoop2 not present in gib-impacted.log, exiting
+ exit 0

Copy link
Copy Markdown
Member

@findepi findepi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ebyhr ebyhr merged commit d2ffc3b into trinodb:master Jul 20, 2022
@ebyhr ebyhr deleted the ebi/hive-alluxio-disable branch July 20, 2022 22:40
@ebyhr
Copy link
Copy Markdown
Member Author

ebyhr commented Jul 20, 2022

Filed #13270

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants