Skip to content

Disable testGetPartitionsWithFilter test in Alluxio #13252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ebyhr merged 1 commit into from
Jul 20, 2022
Merged

Disable testGetPartitionsWithFilter test in Alluxio #13252

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions plugin/trino-hive-hadoop2/src/test/java/io/trino/plugin/hive/TestHiveAlluxioMetastore.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,6 +161,12 @@ public void testGetPartitionsWithBindings()
// Alluxio metastore treats null comment as empty comment
}

@Override
public void testGetPartitionsWithFilter()
{
// Alluxio metastore returns incorrect results
Copy link
Copy Markdown
Member

@findepi findepi Jul 20, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

woah.
is it sometimes or always? (#13122 didn't have alluxio failures, right)

if Alluxio metastore is not correct, maybe we should disable that integration by default
and require some flag to enable it.
or add some docs entry cc @mosabua

Copy link
Copy Markdown
Member Author

@ebyhr ebyhr Jul 20, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's always as far as I confirmed. CI was green (https://github.com/trinodb/trino/runs/7422392334) in #13122, but I suppose it didn't run any tests somehow. cc: @nineinchnick

+ . plugin/trino-hive-hadoop2/bin/common.sh
++ SCRIPT_DIR=plugin/trino-hive-hadoop2/bin
++ INTEGRATION_TESTS_ROOT=plugin/trino-hive-hadoop2/bin/..
++ PROJECT_ROOT=plugin/trino-hive-hadoop2/bin/../../..
++ DOCKER_COMPOSE_LOCATION=plugin/trino-hive-hadoop2/bin/../conf/docker-compose.yml
++ source plugin/trino-hive-hadoop2/bin/../conf/hive-tests-defaults.sh
++++ ./mvnw help:evaluate -Dexpression=dep.docker.images.version -q -DforceStdout
+++ DEFAULT_DOCKER_VERSION=64
+++ '[' -z 64 ']'
+++ export DOCKER_IMAGES_VERSION=64
+++ DOCKER_IMAGES_VERSION=64
+++ export HADOOP_BASE_IMAGE=ghcr.io/trinodb/testing/hdp2.6-hive
+++ HADOOP_BASE_IMAGE=ghcr.io/trinodb/testing/hdp2.6-hive
++ docker-compose version
docker-compose version 1.29.2, build 5becea4c
docker-py version: 5.0.0
CPython version: 3.7.10
OpenSSL version: OpenSSL 1.1.0l  10 Sep 2019
++ docker version
Client:
 Version:           20.10.[17](https://github.com/trinodb/trino/runs/7422392334?check_suite_focus=true#step:14:18)+azure-1
 API version:       1.41
 Go version:        go1.17.11
 Git commit:        100c70[18](https://github.com/trinodb/trino/runs/7422392334?check_suite_focus=true#step:14:19)0fde3601def79a59cc3e996aa553c9b9
 Built:             Mon Jun  6 21:36:39 UTC 2022
 OS/Arch:           linux/amd64
 Context:           default
 Experimental:      true
Server:
 Engine:
  Version:          20.10.17+azure-1
  API version:      1.41 (minimum version 1.12)
  Go version:       go1.17.11
  Git commit:       a89b84221c8560e7a3dee2a653353429e7628424
  Built:            Mon Jun  6 22:32:38 2022
  OS/Arch:          linux/amd64
  Experimental:     false
 containerd:
  Version:          1.5.13+azure-1
  GitCommit:        a17ec496a95e55601607ca50828147e8ccaeebf1
 runc:
  Version:          1.0.3
  GitCommit:        f46b6ba2c9314cfc8caae24a32ec5fe9ef1059fe
 docker-init:
  Version:          0.[19](https://github.com/trinodb/trino/runs/7422392334?check_suite_focus=true#step:14:20).0
  GitCommit:        
++ '[' -n '' ']'
++ PROXY=1[27](https://github.com/trinodb/trino/runs/7422392334?check_suite_focus=true#step:14:28).0.0.1
+ abort_if_not_gib_impacted
+ local module=plugin/trino-hive-hadoop2
+ local impacted_log=gib-impacted.log
+ '[' -f gib-impacted.log ']'
+ grep -q '^plugin/trino-hive-hadoop2$' gib-impacted.log
+ echo 'Module plugin/trino-hive-hadoop2 not present in gib-impacted.log, exiting'
Module plugin/trino-hive-hadoop2 not present in gib-impacted.log, exiting
+ exit 0

}

@Override
public void testGetPartitionSplitsTableOfflinePartition()
{
Expand Down