Revert "Retry TestingTrinoServer setup when port is already used"#13247
Merged
Revert "Retry TestingTrinoServer setup when port is already used"#13247
Conversation
This reverts commit 5a72170. The change was not necessary. The rationale was Even we typically use random port to setup TestingTrinoServer there is a low likelihood of a race condition where same port is used by two concurrent tests. However, in practice, we always bind to 0, and such a bind is guaranteed to succeed. If a specific test binds to a specific port, it's this test's responsibility to guarantee the port is free, not `TestingTrinoServer`'s.
hashhar
approved these changes
Jul 20, 2022
kokosing
approved these changes
Jul 20, 2022
Member
Author
|
Hive tests fixed in #13252 |
Member
Author
|
previous Ci: #13288 |
findepi
force-pushed
the
revert-13077-origin/master/305_retry
branch
from
3d28bd3 to
e45b8fc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 5a72170. The change
was not necessary. The rationale was
However, in practice, we always bind to 0, and such a bind is guaranteed
to succeed. If a specific test binds to a specific port, it's this
test's responsibility to guarantee the port is free, not
TestingTrinoServer's.Reverts #13077