Skip to content

Share nothing when the table snapshots cache is disabled #13086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ebyhr merged 1 commit into from
Jul 6, 2022
Merged

Share nothing when the table snapshots cache is disabled #13086

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ...lta-lake/src/main/java/io/trino/plugin/deltalake/transactionlog/TransactionLogAccess.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,7 @@ public TransactionLogAccess(

tableSnapshots = EvictableCacheBuilder.newBuilder()
.expireAfterWrite(deltaLakeConfig.getMetadataCacheTtl().toMillis(), TimeUnit.MILLISECONDS)
.shareNothingWhenDisabled()
.recordStats()
.build();
activeDataFileCache = EvictableCacheBuilder.newBuilder()
Expand Down
41 changes: 40 additions & 1 deletion ...in/trino-delta-lake/src/test/java/io/trino/plugin/deltalake/TestTransactionLogAccess.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
import com.google.common.collect.ImmutableMap;
import com.google.common.collect.ImmutableSet;
import com.google.common.io.Files;
import io.airlift.units.Duration;
import io.trino.plugin.deltalake.transactionlog.AddFileEntry;
import io.trino.plugin.deltalake.transactionlog.CommitInfoEntry;
import io.trino.plugin.deltalake.transactionlog.MetadataEntry;
Expand Down Expand Up @@ -54,6 +55,7 @@
import java.util.Map;
import java.util.Optional;
import java.util.Set;
import java.util.concurrent.TimeUnit;
import java.util.stream.Collectors;
import java.util.stream.Stream;

Expand Down Expand Up @@ -110,6 +112,12 @@ private void setupTransactionLogAccess(String tableName)

private void setupTransactionLogAccess(String tableName, Path tableLocation)
throws IOException
{
setupTransactionLogAccess(tableName, tableLocation, new DeltaLakeConfig());
}

private void setupTransactionLogAccess(String tableName, Path tableLocation, DeltaLakeConfig deltaLakeConfig)
throws IOException
{
TestingConnectorContext context = new TestingConnectorContext();
TypeManager typeManager = context.getTypeManager();
Expand All @@ -125,7 +133,7 @@ private void setupTransactionLogAccess(String tableName, Path tableLocation)
SESSION,
typeManager,
new CheckpointSchemaManager(typeManager),
new DeltaLakeConfig(),
deltaLakeConfig,
fileFormatDataSourceStats,
hdfsEnvironment,
new ParquetReaderConfig());
Expand Down Expand Up @@ -697,6 +705,37 @@ public void testParquetStructStatistics()
}
}

@Test
public void testTableSnapshotsCacheDisabled()
throws Exception
{
String tableName = "person";
Path tableDir = new Path(getClass().getClassLoader().getResource("databricks/" + tableName).toURI());
DeltaLakeConfig cacheDisabledConfig = new DeltaLakeConfig();
cacheDisabledConfig.setMetadataCacheTtl(new Duration(0, TimeUnit.SECONDS));
setupTransactionLogAccess(tableName, tableDir, cacheDisabledConfig);

assertEquals(
transactionLogAccess.getAccessTrackingFileSystem().getOpenCount(),
ImmutableMap.of(
"_last_checkpoint", 1,
"00000000000000000011.json", 1,
"00000000000000000012.json", 1,
"00000000000000000013.json", 1,
"00000000000000000014.json", 1));

// With the transaction log cache disabled, when loading the snapshot again, all the needed files will be opened again
transactionLogAccess.loadSnapshot(new SchemaTableName("schema", tableName), tableDir, SESSION);
assertEquals(
transactionLogAccess.getAccessTrackingFileSystem().getOpenCount(),
ImmutableMap.of(
"_last_checkpoint", 2,
"00000000000000000011.json", 2,
"00000000000000000012.json", 2,
"00000000000000000013.json", 2,
"00000000000000000014.json", 2));
}

private void copyTransactionLogEntry(int startVersion, int endVersion, File sourceDir, File targetDir)
throws IOException
{
Expand Down