Skip to content

Convert Kudu connector test variants to smoke tests #13057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ebyhr merged 1 commit into from
Jul 1, 2022
Merged

Convert Kudu connector test variants to smoke tests #13057

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion plugin/trino-kudu/src/test/java/io/trino/plugin/kudu/BaseKuduConnectorSmokeTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ protected String getCreateTableDefaultDefinition()
public void testShowCreateTable()
{
assertThat((String) computeScalar("SHOW CREATE TABLE region"))
.isEqualTo("CREATE TABLE kudu.tpch.region (\n" +
.isEqualTo("CREATE TABLE kudu." + getSession().getSchema().orElseThrow() + ".region (\n" +
" regionkey bigint COMMENT '' WITH ( nullable = true ),\n" +
" name varchar COMMENT '' WITH ( nullable = true ),\n" +
" comment varchar COMMENT '' WITH ( nullable = true )\n" +
Expand Down
24 changes: 4 additions & 20 deletions ...WithDisabledInferSchemaConnectorTest.java → ...isabledInferSchemaConnectorSmokeTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,8 @@
import static org.assertj.core.api.Assertions.assertThat;
import static org.assertj.core.api.Assertions.assertThatThrownBy;

public abstract class AbstractKuduWithDisabledInferSchemaConnectorTest
extends AbstractKuduConnectorTest
public abstract class BaseKuduWithDisabledInferSchemaConnectorSmokeTest
extends BaseKuduConnectorSmokeTest
{
@Override
protected Optional<String> getKuduSchemaEmulationPrefix()
Expand Down Expand Up @@ -59,25 +59,9 @@ public void testCreateSchema()

@Test
@Override
public void testRenameTableAcrossSchema()
public void testRenameTableAcrossSchemas()
{
assertThatThrownBy(super::testRenameTableAcrossSchema)
.hasMessage("Creating schema in Kudu connector not allowed if schema emulation is disabled.");
}

@Test
@Override
public void testRenameTableToUnqualifiedPreservesSchema()
{
assertThatThrownBy(super::testRenameTableToUnqualifiedPreservesSchema)
.hasMessage("Creating schema in Kudu connector not allowed if schema emulation is disabled.");
}

@Test
@Override
public void testDropNonEmptySchemaWithTable()
{
assertThatThrownBy(super::testDropNonEmptySchemaWithTable)
assertThatThrownBy(super::testRenameTableAcrossSchemas)
.hasMessage("Creating schema in Kudu connector not allowed if schema emulation is disabled.");
}
}
42 changes: 35 additions & 7 deletions ...lugin/kudu/AbstractKuduConnectorTest.java → ...no/plugin/kudu/TestKuduConnectorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,21 +39,17 @@
import static org.testng.Assert.assertNull;
import static org.testng.Assert.assertTrue;

public abstract class AbstractKuduConnectorTest
public class TestKuduConnectorTest
extends BaseConnectorTest
{
private TestingKuduServer kuduServer;

protected abstract String getKuduServerVersion();

protected abstract Optional<String> getKuduSchemaEmulationPrefix();

@Override
protected QueryRunner createQueryRunner()
throws Exception
{
kuduServer = new TestingKuduServer(getKuduServerVersion());
return createKuduQueryRunnerTpch(kuduServer, getKuduSchemaEmulationPrefix(), REQUIRED_TPCH_TABLES);
kuduServer = new TestingKuduServer();
return createKuduQueryRunnerTpch(kuduServer, Optional.empty(), REQUIRED_TPCH_TABLES);
}

@AfterClass(alwaysRun = true)
Expand Down Expand Up @@ -89,6 +85,38 @@ protected boolean hasBehavior(TestingConnectorBehavior connectorBehavior)
}
}

@Test
@Override
public void testCreateSchema()
{
assertThatThrownBy(super::testCreateSchema)
.hasMessage("Creating schema in Kudu connector not allowed if schema emulation is disabled.");
}

@Test
@Override
public void testDropNonEmptySchemaWithTable()
{
assertThatThrownBy(super::testDropNonEmptySchemaWithTable)
.hasMessage("Creating schema in Kudu connector not allowed if schema emulation is disabled.");
}

@Test
@Override
public void testRenameTableAcrossSchema()
{
assertThatThrownBy(super::testRenameTableAcrossSchema)
.hasMessage("Creating schema in Kudu connector not allowed if schema emulation is disabled.");
}

@Test
@Override
public void testRenameTableToUnqualifiedPreservesSchema()
{
assertThatThrownBy(super::testRenameTableToUnqualifiedPreservesSchema)
.hasMessage("Creating schema in Kudu connector not allowed if schema emulation is disabled.");
}

@Test
@Override
public void testDescribeTable()
Expand Down
4 changes: 2 additions & 2 deletions ...WithDisabledInferSchemaConnectorTest.java → ...isabledInferSchemaConnectorSmokeTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@

import static io.trino.plugin.kudu.TestingKuduServer.LATEST_TAG;

public class TestKuduLatestWithDisabledInferSchemaConnectorTest
extends AbstractKuduWithDisabledInferSchemaConnectorTest
public class TestKuduLatestWithDisabledInferSchemaConnectorSmokeTest
extends BaseKuduWithDisabledInferSchemaConnectorSmokeTest
{
@Override
protected String getKuduServerVersion()
Expand Down
4 changes: 2 additions & 2 deletions ...WithDisabledInferSchemaConnectorTest.java → ...isabledInferSchemaConnectorSmokeTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@

import static io.trino.plugin.kudu.TestingKuduServer.EARLIEST_TAG;

public class TestKuduWithDisabledInferSchemaConnectorTest
extends AbstractKuduWithDisabledInferSchemaConnectorTest
public class TestKuduWithDisabledInferSchemaConnectorSmokeTest
extends BaseKuduWithDisabledInferSchemaConnectorSmokeTest
{
@Override
protected String getKuduServerVersion()
Expand Down