Skip to content

Disallow creating views in a schema where it doesn't exist in Accumulo connector#12481

Closed
Dark-Knight11 wants to merge 2 commits intotrinodb:masterfrom
Dark-Knight11:dark-knight-patch-1
Closed

Disallow creating views in a schema where it doesn't exist in Accumulo connector#12481
Dark-Knight11 wants to merge 2 commits intotrinodb:masterfrom
Dark-Knight11:dark-knight-patch-1

Conversation

@Dark-Knight11
Copy link
Copy Markdown
Member

@Dark-Knight11 Dark-Knight11 commented May 19, 2022

Description

Fix Accumulo connector to disallow creating views in a schema where it doesn't exist

Related issues, pull requests, and links

Fixes #12475

Documentation

(x) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.

Release notes

( ) No release notes entries required.
(x) Release notes entries required with the following suggested text:

# Accumulo
* Disallow creating views in a schema where it doesn't exist. ({issue}`12475`)

@cla-bot
Copy link
Copy Markdown

cla-bot bot commented May 19, 2022

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please submit the signed CLA to cla@trino.io. For more information, see https://github.com/trinodb/cla.

Copy link
Copy Markdown
Member

@ebyhr ebyhr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase on upstream (instead of merge) and fix the commit title as

Disallow creating view if schema doesn't exist in Accumulo

Have you already submit CLA?

@ebyhr
Copy link
Copy Markdown
Member

ebyhr commented May 20, 2022

This PR should be merged after #12453 considering the test.

@ebyhr ebyhr changed the title fix Accumulo connector allows creating views in a schema where it doesn't exist Disallow creating views in a schema where it doesn't exist in Accumulo connector May 20, 2022
@Dark-Knight11
Copy link
Copy Markdown
Member Author

Created a new PR for this #12492

Have you already submit CLA?
Yes

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Accumulo connector allows creating views in a schema where it doesn't exist

2 participants