File-metastore do not allow createing view when schema is not exist#12453
File-metastore do not allow createing view when schema is not exist#12453Emor-nj wants to merge 14 commits intotrinodb:masterfrom
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please submit the signed CLA to cla@trino.io. For more information, see https://github.com/trinodb/cla. |
|
cc @ebyhr Pelase check and give me some advice. Thank you very much. |
ebyhr
left a comment
ebyhr
left a comment
There was a problem hiding this comment.
Could you add a test to BaseConnectorTest? You can refer to existing testCreateTableSchemaNotFound() test.
Emor-nj
force-pushed
the
fixhivefilemetastore
branch
from
b307b3b to
62f1e71
Compare
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please submit the signed CLA to cla@trino.io. For more information, see https://github.com/trinodb/cla. |
|
ebyhr
left a comment
ebyhr
left a comment
There was a problem hiding this comment.
Could you confirm CI failure except for TestMySqlTableStatisticsMySql8Histograms?
There was a problem hiding this comment.
@ebyhr
I found that the reason ci failure is trino-accumulo and trino-raptor-legacy have the same issue with HiveFileMetastore.
They both allow createing view when schema is not exist, so it caused the unit test testCreateTableSchemaNotFound() failed.
I think we can overwrite function testCreateTableSchemaNotFound() in class TestAccumuloConnectorTest and BaseRaptorConnectorTest to skip.
Then i will open new issue and pr about accumulo and raptor to solve this bug.
What do you think?
There was a problem hiding this comment.
Good catch. Please file an issue for Accumulo. There's no need to file an issue for Raptor since it's same as #11110
There was a problem hiding this comment.
sorry, something conflict with this pr and i resolve it failed,so i had opened another #12482
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please submit the signed CLA to cla@trino.io. For more information, see https://github.com/trinodb/cla. |
The reason is that condition `replace` is always 'true' when reached.
The reason is that condition `b.getClass().isArray()` is always 'true' when reached.
The reason is that the method `all` is annotated as `@NonNull`.
Not partitioned lookup source has better performance than partitioned one so for small build side the overall join performance is better even if the lookup source is created using a single thread.
Statement ordering was incorrect previously and routine to process pending acquires was woken up before whole state related to released node was updated. It could still be observed by routine that released node is occupied and pending acquire was not fulfilled.
Input and output aggregation methods require a specific parameter order but this not was being enforces by the annotation parser. Instead this error causes confusing runtime errors. Additionally, it appears that in older versions of Trino alternative parameter orders were allowed, and there was a test for that. This test is invalid and had been adjusted to ensure proper exceptions are thrown.
The same table name was used in testMismatchedBucketing.
Emor-nj
force-pushed
the
fixhivefilemetastore
branch
from
7671d64 to
bbb5f46
Compare
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please submit the signed CLA to cla@trino.io. For more information, see https://github.com/trinodb/cla. |
|
@Emor-nj I can share some git commands in Slack. Please feel free to ping me in https://trino.io/slack.html |
6 participants
Description
Fix file-metastore allows creating views in a schema where it doesn't exist
Related issues, pull requests, and links
Fixes #10857
Documentation
No documentation is needed.
Release notes
No release notes entries required.