Skip to content

Disallow creating view if schema doesn't exist in Accumulo#12492

Merged
ebyhr merged 1 commit intotrinodb:masterfrom
Dark-Knight11:master
Jun 9, 2022
Merged

Disallow creating view if schema doesn't exist in Accumulo#12492
ebyhr merged 1 commit intotrinodb:masterfrom
Dark-Knight11:master

Conversation

@Dark-Knight11
Copy link
Copy Markdown
Member

Description

Disallow creating view if schema doesn't exist in Accumulo

Related issues, pull requests, and links

Fixes #12475

Documentation

(x) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.

Release notes

( ) No release notes entries required.
(x) Release notes entries required with the following suggested text:

# Accumulo
* Disallow creating views in a schema where it doesn't exist. ({issue}`12475`)

@cla-bot
Copy link
Copy Markdown

cla-bot bot commented May 20, 2022

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please submit the signed CLA to cla@trino.io. For more information, see https://github.com/trinodb/cla.

@ebyhr
Copy link
Copy Markdown
Member

ebyhr commented May 21, 2022

This PR depends on #12482. You will need to remove testCreateViewSchemaNotFound() from TestAccumuloConnectorTest once the PR is merged.

@Dark-Knight11
Copy link
Copy Markdown
Member Author

Hi, any update on the 12482 pr?
When it will be merged?

@ebyhr
Copy link
Copy Markdown
Member

ebyhr commented May 26, 2022

It will be merged after CLA registration.

@ebyhr
Copy link
Copy Markdown
Member

ebyhr commented Jun 7, 2022

@cla-bot check

@cla-bot cla-bot bot added the cla-signed label Jun 7, 2022
@cla-bot
Copy link
Copy Markdown

cla-bot bot commented Jun 7, 2022

The cla-bot has been summoned, and re-checked this pull request!

Copy link
Copy Markdown
Member

@ebyhr ebyhr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase on upstream and remove TestAccumuloConnectorTest.testCreateViewSchemaNotFound().

@Dark-Knight11 Dark-Knight11 force-pushed the master branch 2 times, most recently from cc7ed62 to b16a1ca Compare June 8, 2022 10:19
@ebyhr
Copy link
Copy Markdown
Member

ebyhr commented Jun 8, 2022

Please squash commits into one.

@ebyhr
Copy link
Copy Markdown
Member

ebyhr commented Jun 8, 2022

Please fix checkstyle error.

@Dark-Knight11 Dark-Knight11 requested a review from ebyhr June 9, 2022 07:31
@ebyhr ebyhr merged commit 237954b into trinodb:master Jun 9, 2022
@github-actions github-actions bot added this to the 386 milestone Jun 9, 2022
@ebyhr ebyhr mentioned this pull request Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

Accumulo connector allows creating views in a schema where it doesn't exist

2 participants