Fix prometheus connector to work with prometheuses on sub-path#11578
Fix prometheus connector to work with prometheuses on sub-path#11578Muxa1L wants to merge 4 commits intotrinodb:masterfrom
Conversation
Fix to work with prometheus working in non-root
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please submit the signed CLA to cla@trino.io. For more information, see https://github.com/trinodb/cla. |
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please submit the signed CLA to cla@trino.io. For more information, see https://github.com/trinodb/cla. |
|
LGTM, but one thing, you said no docs needed, but maybe we should let users know this is happening with the URI and why? It may help them debug if it's not working. |
|
Superseded by #12391 |
Description
This fix is for prometheus connector, aimed to allow trino work with prometheus'es working with api exposed in non-root url (behind reverse proxy or victoriametrics in cluster mode, needing to use urls like /select/<tenantid>/prometheus/api/.... )
Trino can get table (metric) names correctly but cant get any values for them.
And if you set uri with sub-path in prometheus.uri - this subpath is overwrited by this code.
Related issues, pull requests, and links
Documentation
( ) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
( ) No release notes entries required.
( ) Release notes entries required with the following suggested text: