Clean up join pushdown docs for JDBC connectors#11967
Merged
hashhar merged 1 commit intotrinodb:masterfrom Apr 15, 2022
Merged
Conversation
mosabua
approved these changes
Apr 14, 2022
Member
mosabua
left a comment
There was a problem hiding this comment.
One minor correction .. the rest looks good.
docs/src/main/sphinx/connector/join-pushdown-enabled-false.fragment
Outdated
Show resolved
Hide resolved
f4ae525 to
f7b68f2
Compare
mosabua
reviewed
Apr 14, 2022
docs/src/main/sphinx/connector/join-pushdown-enabled-false.fragment
Outdated
Show resolved
Hide resolved
f7b68f2 to
59dfd68
Compare
hashhar
reviewed
Apr 15, 2022
docs/src/main/sphinx/connector/join-pushdown-enabled-true.fragment
Outdated
Show resolved
Hide resolved
docs/src/main/sphinx/connector/join-pushdown-enabled-true.fragment
Outdated
Show resolved
Hide resolved
59dfd68 to
55be1fd
Compare
hashhar
approved these changes
Apr 15, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
With table statistics & cost-based join pushdowns added to select JDBC connectors, the
join-pushdown.enabledproperty which previously defaulted tofalseon all JDBC connectors now defaults totruein these select connectors. This PR updates adds doc fragments that now accurately describe this property and its default value on a per-connector basis, as well as the needed title level and structure consistency changes needed to implement this improvement.Improvement
Documentation
Make the join pushdown documentation consistent across connectors, while adding corrected information on how to configure join pushdown on JDBC connectors
Related issues, pull requests, and links
Documentation
( ) No documentation is needed.
(x) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
(x) No release notes entries required.
( ) Release notes entries required with the following suggested text: