Add table statistics, automatic Join pushdown, TopN pushdown for Oracle connector#11636
Closed
findepi wants to merge 3 commits intotrinodb:masterfrom
Closed
Add table statistics, automatic Join pushdown, TopN pushdown for Oracle connector#11636findepi wants to merge 3 commits intotrinodb:masterfrom
findepi wants to merge 3 commits intotrinodb:masterfrom
Conversation
Member
Author
|
Currently based on #11635 |
findepi
force-pushed
the
findepi/rdbms-stats-oracle
branch
2 times, most recently
from
03b7ed6 to
399d02f
Compare
Member
Author
|
Some prefix extracted to #11657 |
findepi
force-pushed
the
findepi/rdbms-stats-oracle
branch
from
399d02f to
eb5ad14
Compare
hashhar
reviewed
Mar 31, 2022
Member
hashhar
left a comment
hashhar
left a comment
There was a problem hiding this comment.
LGTM % CI
I think we need to use newer Oracle version. Note that 12 is also reaching EOL in few months according to https://support.oracle.com/knowledge/Oracle%20Database%20Products/742060_1.html
plugin/trino-oracle/src/main/java/io/trino/plugin/oracle/OracleClient.java
Outdated
Show resolved
Hide resolved
plugin/trino-oracle/src/main/java/io/trino/plugin/oracle/OracleClient.java
Outdated
Show resolved
Hide resolved
Member
Author
Yes, we need 12c or better (for TopN pushdown to work) and we also need Enterprise Edition (EE) to test stats and TopN pushdown with partitioning. I already started a thread within maintainers group about that. |
findepi
force-pushed
the
findepi/rdbms-stats-oracle
branch
from
eb5ad14 to
02e4558
Compare
findepi
changed the title
Member
Author
|
Some prefix extracted to #11981 |
findepi
force-pushed
the
findepi/rdbms-stats-oracle
branch
from
02e4558 to
5ae30ea
Compare
findepi
force-pushed
the
findepi/rdbms-stats-oracle
branch
from
5ae30ea to
50958d8
Compare
Member
Author
rebased after this merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀