Add table statistics and automatic Join pushdown for PostgreSQL connector#11635
Merged
findepi merged 4 commits intotrinodb:masterfrom Mar 24, 2022
Merged
Add table statistics and automatic Join pushdown for PostgreSQL connector#11635findepi merged 4 commits intotrinodb:masterfrom
findepi merged 4 commits intotrinodb:masterfrom
Conversation
hashhar
reviewed
Mar 24, 2022
Member
hashhar
left a comment
hashhar
left a comment
There was a problem hiding this comment.
Couple comments about tests.
Looks good to me otherwise.
plugin/trino-base-jdbc/src/test/java/io/trino/plugin/jdbc/BaseJdbcTableStatisticsTest.java
Outdated
Show resolved
Hide resolved
plugin/trino-postgresql/src/main/java/io/trino/plugin/postgresql/PostgreSqlClient.java
Outdated
Show resolved
Hide resolved
...trino-postgresql/src/test/java/io/trino/plugin/postgresql/TestPostgreSqlTableStatistics.java
Outdated
Show resolved
Hide resolved
...trino-postgresql/src/test/java/io/trino/plugin/postgresql/TestPostgreSqlTableStatistics.java
Outdated
Show resolved
Hide resolved
This will be leveraged by connectors which gain table stats support in the future.
findepi
force-pushed
the
findepi/rdbms-stats-postgresql
branch
from
9403ba3 to
447515f
Compare
hashhar
approved these changes
Mar 24, 2022
Member
hashhar
left a comment
hashhar
left a comment
There was a problem hiding this comment.
LGTM. We'll address followups after other two PRs are also merged (so it's easier to see patterns).
ebyhr
approved these changes
Mar 24, 2022
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀