Use valid package name in a test exception assert#10862
Closed
nineinchnick wants to merge 1 commit intotrinodb:masterfrom
Closed
Use valid package name in a test exception assert#10862nineinchnick wants to merge 1 commit intotrinodb:masterfrom
nineinchnick wants to merge 1 commit intotrinodb:masterfrom
Conversation
kokosing
reviewed
Jan 31, 2022
| // Hive expects `FIXED_LEN_BYTE_ARRAY` for decimal values irrespective of the Parquet specification which allows `INT32`, `INT64` for short precision decimal types | ||
| assertQueryFailure(() -> onHive().executeQuery("SELECT a_decimal FROM " + tableName)) | ||
| .hasMessageMatching(".* org.apache.parquet.io.ParquetDecodingException: Can not read value at 1 in block 0 in file .*"); | ||
| .hasMessageMatching(".* parquet.io.ParquetDecodingException: Can not read value at 1 in block 0 in file .*"); |
Member
There was a problem hiding this comment.
Maybe we should not validate the package at all? Why the package got changed? Maybe different Hadoop distros are using different parquet libraries?
Member
Author
There was a problem hiding this comment.
The original PR doesn't have the CI run completed, so I can't tell if it changed, or was just incorrect.
Member
Author
|
Duplicate of #10847 |
Member
|
@nineinchnick @findinpath at some point Parquet had packages renamed, so different Hive versions have Parquet lib in either |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm seeing a lot of failures on master in a test that was recently introduced in #10613
with the following error: