Skip to content

Use valid package name in a test exception assert #10862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nineinchnick wants to merge 1 commit into from
Closed

Use valid package name in a test exception assert #10862

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .../trino-product-tests/src/main/java/io/trino/tests/product/hive/TestHiveCompatibility.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,7 @@ public void testSmallDecimalFieldWrittenByOptimizedParquetWriterCannotBeReadByHi

// Hive expects `FIXED_LEN_BYTE_ARRAY` for decimal values irrespective of the Parquet specification which allows `INT32`, `INT64` for short precision decimal types
assertQueryFailure(() -> onHive().executeQuery("SELECT a_decimal FROM " + tableName))
.hasMessageMatching(".* org.apache.parquet.io.ParquetDecodingException: Can not read value at 1 in block 0 in file .*");
.hasMessageMatching(".* parquet.io.ParquetDecodingException: Can not read value at 1 in block 0 in file .*");
Copy link
Copy Markdown
Member

@kokosing kokosing Jan 31, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should not validate the package at all? Why the package got changed? Maybe different Hadoop distros are using different parquet libraries?

Copy link
Copy Markdown
Member Author

@nineinchnick nineinchnick Jan 31, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original PR doesn't have the CI run completed, so I can't tell if it changed, or was just incorrect.

Copy link
Copy Markdown
Member Author

@nineinchnick nineinchnick Jan 31, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah this is the approach in #10847


onTrino().executeQuery(format("DROP TABLE %s", tableName));
}
Expand Down