Showcase incompatibilities between optimized parquet writer and hive#10613
Merged
findepi merged 2 commits intotrinodb:masterfrom Jan 27, 2022
Conversation
findepi
reviewed
Jan 14, 2022
...ng/trino-product-tests/src/main/java/io/trino/tests/product/hive/TestHiveStorageFormats.java
Outdated
Show resolved
Hide resolved
...ng/trino-product-tests/src/main/java/io/trino/tests/product/hive/TestHiveStorageFormats.java
Outdated
Show resolved
Hide resolved
...ng/trino-product-tests/src/main/java/io/trino/tests/product/hive/TestHiveStorageFormats.java
Outdated
Show resolved
Hide resolved
findinpath
force-pushed
the
showcase-incompatibilities-between-optimized-parquet-writer-and-hive
branch
from
c423590 to
206f1dc
Compare
alexjo2144
reviewed
Jan 14, 2022
Member
There was a problem hiding this comment.
Could be worth having two tests, one with a short timestamp precision and one with a long timestamp precision.
findinpath
force-pushed
the
showcase-incompatibilities-between-optimized-parquet-writer-and-hive
branch
from
206f1dc to
6d2d359
Compare
findepi
approved these changes
Jan 27, 2022
|
|
||
| // Hive expects `FIXED_LEN_BYTE_ARRAY` for decimal values irrespective of the Parquet specification which allows `INT32`, `INT64` for short precision decimal types | ||
| assertQueryFailure(() -> onHive().executeQuery("SELECT a_decimal FROM " + tableName)) | ||
| .hasMessageMatching(".* org.apache.parquet.io.ParquetDecodingException: Can not read value at 1 in block 0 in file .*"); |
Member
There was a problem hiding this comment.
I think this is consistently failing with missing org.apache. in the package name:
tests | 2022-01-31 12:13:37 INFO: FAILURE / io.trino.tests.product.hive.TestHiveCompatibility.testSmallDecimalFieldWrittenByOptimizedParquetWriterCannotBeReadByHive (Groups: storage_formats_detailed) took 0.7 seconds
tests | 2022-01-31 12:13:37 SEVERE: Failure cause:
tests | java.lang.AssertionError:
tests | Expecting message:
tests | <"java.io.IOException: parquet.io.ParquetDecodingException: Can not read value at 1 in block 0 in file hdfs://hadoop-master:9000/user/hive/warehouse/parquet_table_small_decimal_created_in_trino/20220131_062836_01082_j2ikr_8c200c2a-4add-4f35-a3ed-b70c4732e54b">
tests | to match regex:
tests | <".* org.apache.parquet.io.ParquetDecodingException: Can not read value at 1 in block 0 in file .*">
tests | but did not.
Member
There was a problem hiding this comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.