Skip to content

chore(suite-desktop): revert "bump electron-builder"#18183

Merged
martykan merged 1 commit intodevelopfrom
fix/revert-electron-builder-update
Apr 7, 2025
Merged

chore(suite-desktop): revert "bump electron-builder"#18183
martykan merged 1 commit intodevelopfrom
fix/revert-electron-builder-update

Conversation

@martykan
Copy link
Copy Markdown
Member

@martykan martykan commented Apr 7, 2025

Description

After the last Electron-builder update in #18087, Mac builds stopped working in CI/locally due to code-signing issues.

Screenshot 2025-04-07 at 13 12 31

@martykan martykan added no-project This label is used to specify that PR doesn't need to be added to a project build-desktop This will trigger the build of desktop apps for your PR labels Apr 7, 2025
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 7, 2025

🔍🌐 Suite Web test results: View in Currents

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 7, 2025

🔍🖥️ Suite Desktop test results: View in Currents

@martykan martykan marked this pull request as ready for review April 7, 2025 12:09
@martykan martykan requested review from komret and mroz22 as code owners April 7, 2025 12:09
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 7, 2025

Walkthrough

The pull request updates the electron-builder dependency version in the devDependencies section across three different package.json files within the project. In every instance, the version has been changed from "26.0.12" to "26.0.3", reflecting a downgrade of this particular dependency. No other changes have been made to the configuration files or additional dependencies.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b838c4d and 86ef683.

⛔ Files ignored due to path filters (1)
  • yarn.lock is excluded by !**/yarn.lock, !**/*.lock
📒 Files selected for processing (3)
  • packages/connect-examples/electron-main-process/package.json (1 hunks)
  • packages/connect-examples/electron-renderer-with-popup/package.json (1 hunks)
  • packages/suite-desktop/package.json (1 hunks)
🔇 Additional comments (3)
packages/connect-examples/electron-main-process/package.json (1)

60-60: Electron-builder Version Downgrade Verification

The dependency version has been reverted to "26.0.3" as intended. This aligns with the PR objective of reverting the problematic update that caused Mac builds to fail due to code-signing issues. Please ensure that after this change, all build pipelines—especially those on Mac—are re-validated.

packages/connect-examples/electron-renderer-with-popup/package.json (1)

57-57: Consistent Downgrade of Electron-builder

The change to downgrade "electron-builder" from "26.0.12" to "26.0.3" is applied consistently here. This reversion should help resolve the build issues on Mac by using the known stable version. Confirm that this change integrates well with your CI setup.

packages/suite-desktop/package.json (1)

36-36: Electron-builder Reversion in Suite Desktop

The electron-builder dependency is correctly downgraded to "26.0.3", in line with the PR’s goal to revert the previous problematic update. This consistent change across package files is expected to restore Mac build functionality, especially concerning code-signing. It would be beneficial to run a final integration test to verify that the reversion fully resolves the issues.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@martykan martykan merged commit c6fa329 into develop Apr 7, 2025
83 of 84 checks passed
@martykan martykan deleted the fix/revert-electron-builder-update branch April 7, 2025 12:17
@Lemonexe Lemonexe mentioned this pull request May 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build-desktop This will trigger the build of desktop apps for your PR no-project This label is used to specify that PR doesn't need to be added to a project

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants