Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log: revert #2740 #2750

Merged
merged 1 commit into from
Oct 12, 2023
Merged

log: revert #2740 #2750

merged 1 commit into from
Oct 12, 2023

Conversation

davidbarsky
Copy link
Member

Due to minimum version selection issues, a desire to remove the env_logger feature wholesale, and to keep the number of breaking changes to a minimum, I'm reverting #2740 in favor of marking the tracing-log/env_logger feature as deprecated and releasing tracing-log 0.2.0 without env_logger.

@davidbarsky davidbarsky requested review from hawkw and a team as code owners October 12, 2023 23:06
@davidbarsky davidbarsky enabled auto-merge (squash) October 12, 2023 23:15
@davidbarsky davidbarsky merged commit 2297580 into master Oct 12, 2023
55 checks passed
@davidbarsky davidbarsky deleted the davidbarsky/revert-env-logger-bump branch October 12, 2023 23:17
davidbarsky added a commit that referenced this pull request Oct 13, 2023
hawkw added a commit that referenced this pull request Oct 24, 2023
Removing the `env_logger` feature in order to address GHSA-g98v-hv3f-hcfr.

In addition, this PR also removes the deprecated `trace_logger` module, in
preparation for an upcoming v0.2.0 of `tracing-log`.

For additional details on the approach, please refer to #2750. Note that this
PR depends on #2770, so this PR will temporarily have more commits 
than intended. 
---------

Co-authored-by: Eliza Weisman <[email protected]>
kaffarell pushed a commit to kaffarell/tracing that referenced this pull request May 22, 2024
…#2771)

Removing the `env_logger` feature in order to address GHSA-g98v-hv3f-hcfr.

In addition, this PR also removes the deprecated `trace_logger` module, in
preparation for an upcoming v0.2.0 of `tracing-log`.

For additional details on the approach, please refer to tokio-rs#2750. Note that this
PR depends on tokio-rs#2770, so this PR will temporarily have more commits 
than intended. 
---------

Co-authored-by: Eliza Weisman <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants