-
Notifications
You must be signed in to change notification settings - Fork 734
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
log: remove env_logger
feature and usage
#2771
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's also remove the deprecated log-tracer
module. it's probably easier to do that in this PR?
tracing-log/src/lib.rs
Outdated
//! * `trace-logger`: enables an experimental `log` subscriber, deprecated since | ||
//! version 0.1.1. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's also remove this before shipping an 0.2.0? i'm fine with doing that in this PR, or in a separate one, up to you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done in this PR!
Oh, you're right. Let me get on that. |
#[cfg(feature = "trace-logger")] | ||
#[cfg_attr(docsrs, doc(cfg(feature = "trace-logger")))] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since this module had a feature flag, can we also remove the feature flag from the Cargo.toml
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
whoops, sorry—I had completely missed that.
when we removed the `trace_logger` module, we didn't remove the attributes on the module declaration, and they accidentally ended up applying to the `log` crate reexport instead. whoops.
# 0.2.0 (October 24th, 2023) This release contains two breaking changes: the removal of the `env_logger` and `trace_logger` features. Below are the suggested migration paths: - `env_logger`: users should use [`tracing_subscriber::fmt::Subscriber`] or [`tracing_subscriber::fmt::Layer`] with the [`Targets`] or [`EnvFilter`] filters instead. - `trace_logger`: users should use the `tracing` crate's ["log" feature flag][log-feature] instead. ### Breaking Changes - Remove deprecated `env_logger` feature. This removes the dependency on the unmaintained `atty` crate, resolving the security advisory [GHSA-g98v-hv3f-hcfr]/[RUSTSEC-2021-0145]. ([#2771]) - Remove deprecated `trace_logger` feature. ([#2771]) [#2771]: #2771 [`tracing_subscriber::fmt::Subscriber`]: https://docs.rs/tracing-subscriber/0.3.17/tracing_subscriber/fmt/struct.Subscriber.html [`tracing_subscriber::fmt::Layer`]: https://docs.rs/tracing-subscriber/0.3.17/tracing_subscriber/fmt/struct.Layer.html [`Targets`]: https://docs.rs/tracing-subscriber/0.3.17/tracing_subscriber/filter/targets/struct.Targets.html [`EnvFilter`]: https://docs.rs/tracing-subscriber/0.3.17/tracing_subscriber/filter/struct.EnvFilter.html [log-feature]: https://docs.rs/tracing/latest/tracing/#emitting-log-records [GHSA-g98v-hv3f-hcfr]: GHSA-g98v-hv3f-hcfr [RUSTSEC-2021-0145]: https://rustsec.org/advisories/RUSTSEC-2021-0145.html
…#2771) Removing the `env_logger` feature in order to address GHSA-g98v-hv3f-hcfr. In addition, this PR also removes the deprecated `trace_logger` module, in preparation for an upcoming v0.2.0 of `tracing-log`. For additional details on the approach, please refer to tokio-rs#2750. Note that this PR depends on tokio-rs#2770, so this PR will temporarily have more commits than intended. --------- Co-authored-by: Eliza Weisman <[email protected]>
# 0.2.0 (October 24th, 2023) This release contains two breaking changes: the removal of the `env_logger` and `trace_logger` features. Below are the suggested migration paths: - `env_logger`: users should use [`tracing_subscriber::fmt::Subscriber`] or [`tracing_subscriber::fmt::Layer`] with the [`Targets`] or [`EnvFilter`] filters instead. - `trace_logger`: users should use the `tracing` crate's ["log" feature flag][log-feature] instead. ### Breaking Changes - Remove deprecated `env_logger` feature. This removes the dependency on the unmaintained `atty` crate, resolving the security advisory [GHSA-g98v-hv3f-hcfr]/[RUSTSEC-2021-0145]. ([tokio-rs#2771]) - Remove deprecated `trace_logger` feature. ([tokio-rs#2771]) [tokio-rs#2771]: tokio-rs#2771 [`tracing_subscriber::fmt::Subscriber`]: https://docs.rs/tracing-subscriber/0.3.17/tracing_subscriber/fmt/struct.Subscriber.html [`tracing_subscriber::fmt::Layer`]: https://docs.rs/tracing-subscriber/0.3.17/tracing_subscriber/fmt/struct.Layer.html [`Targets`]: https://docs.rs/tracing-subscriber/0.3.17/tracing_subscriber/filter/targets/struct.Targets.html [`EnvFilter`]: https://docs.rs/tracing-subscriber/0.3.17/tracing_subscriber/filter/struct.EnvFilter.html [log-feature]: https://docs.rs/tracing/latest/tracing/#emitting-log-records [GHSA-g98v-hv3f-hcfr]: GHSA-g98v-hv3f-hcfr [RUSTSEC-2021-0145]: https://rustsec.org/advisories/RUSTSEC-2021-0145.html
Removing the
env_logger
feature in order to address GHSA-g98v-hv3f-hcfr.For additional details on the approach, please refer to #2750. Note that this
PR depends on #2770, so this PR will temporarily have more commits
than intended.