Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop comments about using tracing_log::env_logger reexport #95

Merged
merged 4 commits into from
Nov 22, 2023

Conversation

ThibsG
Copy link
Contributor

@ThibsG ThibsG commented Nov 20, 2023

Since tracing_log maintainers are dropping support for env_logger feature, there will be no move later on to use tracing_log::env_logger instead of native env_logger crate.

Allows the full removal of unmaintained atty crate.

Refs:

@ThibsG ThibsG changed the base branch from main to develop November 20, 2023 14:28
@ThibsG ThibsG changed the title Drop env_logger comments Drop comments about using tracing_log::env_logger reexport Nov 20, 2023
@ThibsG ThibsG marked this pull request as ready for review November 20, 2023 15:49
@ThibsG ThibsG requested a review from Manuthor November 20, 2023 15:49
@ThibsG ThibsG force-pushed the drop_tracing_env_logger_comments branch from 859d13b to bc0aad1 Compare November 22, 2023 13:47
@ThibsG ThibsG merged commit 229609e into develop Nov 22, 2023
33 checks passed
@ThibsG ThibsG deleted the drop_tracing_env_logger_comments branch November 22, 2023 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants