Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI job cargo test (stable on windows-latest) failed to compile pprof #39

Closed
ymgyt opened this issue Aug 2, 2023 · 0 comments · Fixed by #40
Closed

CI job cargo test (stable on windows-latest) failed to compile pprof #39

ymgyt opened this issue Aug 2, 2023 · 0 comments · Fixed by #40

Comments

@ymgyt
Copy link
Contributor

ymgyt commented Aug 2, 2023

Bug Report

CI Job cargo test (stable on windows-lates) failed to compile pprof

Version

tracing-opentelemetry v0.19.0

Platform

Github actions windows-latest

Description
@ymgyt ymgyt mentioned this issue Aug 2, 2023
Merged
jtescher pushed a commit that referenced this issue Aug 2, 2023
@ymgyt
chore: use pprof only if target_os is not windows (#40)
d369550 
## Motivation

Fix #39

follow up #36 CI
fail

## Solution

add `#[cfg(not(target_os = "windows"))]` condition to pprof dependencies
@lzchen lzchen mentioned this issue Aug 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: use pprof only if target_os is not windows ymgyt/tracing-opentelemetry
1 participant
@ymgyt