Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use pprof only if target_os is not windows #40

Merged
merged 1 commit into from
Aug 2, 2023

Conversation

ymgyt
Copy link
Contributor

@ymgyt ymgyt commented Aug 2, 2023

Motivation

Fix #39

follow up #36 CI fail

Solution

add #[cfg(not(target_os = "windows"))] condition to pprof dependencies

@ymgyt ymgyt requested a review from jtescher as a code owner August 2, 2023 02:06
Copy link
Collaborator

@jtescher jtescher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ymgyt

@jtescher jtescher merged commit d369550 into tokio-rs:v0.1.x Aug 2, 2023
13 checks passed
@ymgyt ymgyt deleted the pprof-windows branch August 2, 2023 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI job cargo test (stable on windows-latest) failed to compile pprof
2 participants