Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use pprof only if target_os is not windows #1205

Merged
merged 1 commit into from
Aug 12, 2023

Conversation

lzchen
Copy link
Contributor

@lzchen lzchen commented Aug 11, 2023

Following this pr introduced a breaking change for running cargo bench in Windows due to pprof not being able to compile in Windows. Similar to this, only use pprof if not on a Windows machine.

@lzchen lzchen requested a review from a team August 11, 2023 21:53
@codecov
Copy link

codecov bot commented Aug 11, 2023

Codecov Report

Patch coverage: 23.4% and no project coverage change.

Comparison is base (7607ad3) 49.6% compared to head (cc47093) 49.7%.
Report is 8 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #1205   +/-   ##
=====================================
  Coverage   49.6%   49.7%           
=====================================
  Files        164     172    +8     
  Lines      20653   20710   +57     
=====================================
+ Hits       10258   10301   +43     
- Misses     10395   10409   +14     
Files Changed Coverage Δ
opentelemetry-otlp/src/exporter/grpcio/logs.rs 0.0% <0.0%> (ø)
opentelemetry-otlp/src/exporter/grpcio/mod.rs 35.4% <0.0%> (ø)
opentelemetry-otlp/src/exporter/grpcio/trace.rs 0.0% <0.0%> (ø)
opentelemetry-otlp/src/exporter/http/logs.rs 0.0% <0.0%> (ø)
opentelemetry-otlp/src/exporter/http/metrics.rs 0.0% <0.0%> (ø)
opentelemetry-otlp/src/exporter/http/mod.rs 0.0% <0.0%> (ø)
opentelemetry-otlp/src/exporter/http/trace.rs 0.0% <0.0%> (ø)
opentelemetry-otlp/src/exporter/tonic/logs.rs 0.0% <0.0%> (ø)
opentelemetry-otlp/src/exporter/tonic/metrics.rs 0.0% <0.0%> (ø)
opentelemetry-otlp/src/lib.rs 32.2% <ø> (ø)
... and 12 more

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jtescher jtescher merged commit 2848836 into open-telemetry:main Aug 12, 2023
11 of 12 checks passed
@lzchen lzchen deleted the perf branch August 14, 2023 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants