Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Name colors are not converted when creating figma styles #276

Closed
lukasoppermann opened this issue Oct 13, 2021 · 0 comments · Fixed by #226
Closed

Name colors are not converted when creating figma styles #276

lukasoppermann opened this issue Oct 13, 2021 · 0 comments · Fixed by #226
Labels
bug Something isn't working

Comments

@lukasoppermann
Copy link

Describe the bug
When creating a color token using a name, e.g. red it works fine within the plugin. However when creating styles, all colors are black.

While I personally don't really use this feature (apart from testing) if it is supported, you may want to support it all the way.

To Reproduce
Steps to reproduce the behavior:

  1. Create a new color token and set the color value to red
    -> Red color is correctly shown in the plugin
  2. Click the "create styles" button
  3. Styles in figma are black instead of red
@six7 six7 added the bug Something isn't working label Oct 13, 2021
six7 added a commit that referenced this issue Oct 23, 2021
@six7
fixes #276
81c75c6
@six7 six7 mentioned this issue Oct 23, 2021
Merged
7 tasks
@six7 six7 closed this as completed in #226 Oct 31, 2021
six7 added a commit that referenced this issue Oct 31, 2021
@six7
Git Sync, URL Sync & Polish (#226)
df8fddd 
* add initial url sync

* add new provider type

* add form

* add basic functionality

* add working pull

* add push dialog, working state

* added checks for commit message

* add tests

* rework confirm message

* add dirty state

* add test

* fix jsonbin

* remove legacy code

* wip

* fix pullTokens

* add tests

* add first draft of cli script

* fix tests

* add pkg

* working cli tool with github actions

* remove console log

* Add robustness

* bump token-transformer

* prettify ui

* bump release

* add custom branch input to pushDialog

* added loading screen, fixed jsonbin add

* add excludes to token transformer

* add readme to token-transformer

* fix transformer when no excludes are present

* remove token context

* add url sync

* allow users to resize window by dragging corner

* fix url sync

* ignore tokens from style creation that start with _

* fix tooltip render error

* fix tooltip in list mode

* fix resize pointer

* fix #266

* fix colors button row

* fixes #274

* fix / replacement

* fixes #142

* add check for alias

* add token preview in edit

* fix undefined pr state if no file existed

* add editProhibited based on user role

* fix alias value of 0

* add new defaults

* remove spellcheck from inputs

* adds json5 support, fixes #270, fixes #283

* add unique check to names

* fix color opacity values not matching when using 0.5

* fixes #166, fixes #209

* add type to new token creation

* fixes #276

* fixes unique name check

* fix unique name check

* capitalize description in edit form

* introduce new merging function

* fix aliasing of rgba colors

* add new resize icon

* fix capitalization of input labels

* fix name of form

* fix async fn

* correctly saves whole context obj except secret

* add placeholder for value

* fix spec

* fix test

* remove console.log

* fix when no tokens file was present

* integrate style name ignore for updating nodes

* fix ignore part when applying

* fix modal padding except for edit token form

* fix token-transformer

* bump token transformer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Git Sync, URL Sync & Polish tokens-studio/figma-plugin
2 participants
@lukasoppermann @six7