Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Git Sync, URL Sync & Polish #226

Merged
merged 88 commits into from
Oct 31, 2021
Merged

Git Sync, URL Sync & Polish #226

merged 88 commits into from
Oct 31, 2021

Conversation

six7
Copy link
Collaborator

@six7 six7 commented Aug 28, 2021

This PR adds functionality for a sync with GitHub and includes a new URL sync option as well as some other improvements.

GitHub sync

Users would have to create a Personal Access Token with scope repo, define their repo, e.g. six7/figma-tokens define a branch they want to work on and a filename/path (e.g. tokens.json)

Then they'd be able to pull from GitHub and push with a custom commit message

Still open:

  • Improve experience when opening plugin
  • Add dirty state when local changes need to be synced
  • Check and refactor JSONBin integration
  • Add easy PR creation link
  • Enable quick branch switch
  • Write tests
  • Create CLI tool to transform and resolve token object to something style dictionary can read

Resolves #134
Resolves #271

URL sync

  • URL sync option (Add an external URL to sync as a Read Only user. You can also add a JSONBin and access it as a read only user provided you have the credentials) - fixes User roles to avoid editing JSON #251

Other improvements

@six7 six7 changed the title Git sync Git Sync, URL Sync & Polish Oct 23, 2021
@six7 six7 merged commit df8fddd into main Oct 31, 2021
@six7 six7 deleted the git-sync branch November 19, 2021 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment