Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow nesting / grouping of tokens via "/" naming convention #274

Closed
lukasoppermann opened this issue Oct 13, 2021 · 0 comments · Fixed by #226
Closed

Allow nesting / grouping of tokens via "/" naming convention #274

lukasoppermann opened this issue Oct 13, 2021 · 0 comments · Fixed by #226
Labels
enhancement Internal new feature or functionality

Comments

@lukasoppermann
Copy link

Is your feature request related to a problem? Please describe.
I needed a moment to test and find out that one needs to use a . to indicate levels.
While this mirrors the json structure and makes sense as such, it can be a bit confusing as figma uses the /convention.

-> Bug: When I used / my color somehow disappeared.

Describe the solution you'd like
When user enter names nested tokens using / like core/green the plugin should accept it and changing it to dots behind the scene.

The next time the user edits the name, the . is show instead of the slash.

Additional context
I don't know if I am missing something here, but you can probably not use a / in the names anyway, as it would interfere with figma.

@six7 six7 added the enhancement Internal new feature or functionality label Oct 13, 2021
six7 added a commit that referenced this issue Oct 17, 2021
This was referenced Oct 17, 2021
@six7 six7 closed this as completed in #226 Oct 31, 2021
six7 added a commit that referenced this issue Oct 31, 2021
* add initial url sync

* add new provider type

* add form

* add basic functionality

* add working pull

* add push dialog, working state

* added checks for commit message

* add tests

* rework confirm message

* add dirty state

* add test

* fix jsonbin

* remove legacy code

* wip

* fix pullTokens

* add tests

* add first draft of cli script

* fix tests

* add pkg

* working cli tool with github actions

* remove console log

* Add robustness

* bump token-transformer

* prettify ui

* bump release

* add custom branch input to pushDialog

* added loading screen, fixed jsonbin add

* add excludes to token transformer

* add readme to token-transformer

* fix transformer when no excludes are present

* remove token context

* add url sync

* allow users to resize window by dragging corner

* fix url sync

* ignore tokens from style creation that start with _

* fix tooltip render error

* fix tooltip in list mode

* fix resize pointer

* fix #266

* fix colors button row

* fixes #274

* fix / replacement

* fixes #142

* add check for alias

* add token preview in edit

* fix undefined pr state if no file existed

* add editProhibited based on user role

* fix alias value of 0

* add new defaults

* remove spellcheck from inputs

* adds json5 support, fixes #270, fixes #283

* add unique check to names

* fix color opacity values not matching when using 0.5

* fixes #166, fixes #209

* add type to new token creation

* fixes #276

* fixes unique name check

* fix unique name check

* capitalize description in edit form

* introduce new merging function

* fix aliasing of rgba colors

* add new resize icon

* fix capitalization of input labels

* fix name of form

* fix async fn

* correctly saves whole context obj except secret

* add placeholder for value

* fix spec

* fix test

* remove console.log

* fix when no tokens file was present

* integrate style name ignore for updating nodes

* fix ignore part when applying

* fix modal padding except for edit token form

* fix token-transformer

* bump token transformer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Internal new feature or functionality
Projects
None yet
2 participants