Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(blocks): improve state initialization in EmbedLinkedDocBlockComponent #8354

Merged
merged 1 commit into from
Sep 13, 2024
Merged

refactor(blocks): improve state initialization in EmbedLinkedDocBlockComponent #8354

merged 1 commit into from
Sep 13, 2024

Conversation

fundon
Copy link
Contributor

@fundon fundon commented Sep 13, 2024 •
edited
Loading

Closes BS-1417

@vercel Vercel
Copy link

vercel bot commented Sep 13, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blocksuite ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 13, 2024 0:54am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
blocksuite-docs ⬜️ Ignored (Inspect) Visit Preview Sep 13, 2024 0:54am

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Sep 13, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 9f1edb4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@graphite-app Graphite App
Copy link

graphite-app bot commented Sep 13, 2024

Your org has enabled the Graphite merge queue for merging into master

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@fundon Graphite App
Copy link
Contributor Author

fundon commented Sep 13, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @fundon and the rest of your teammates on Graphite Graphite

@fundon fundon marked this pull request as ready for review September 13, 2024 11:34
@fundon fundon requested a review from a team as a code owner September 13, 2024 11:34
@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Sep 13, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 9f1edb4. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 13, 2024 •
edited
Loading

size-limit report 📦

Path Size
@blocksuite/affine-block-list 5.94 KB (0%)
@blocksuite/affine-block-paragraph 4.5 KB (0%)
@blocksuite/affine-block-surface 82.11 KB (0%)
@blocksuite/affine-components 366.81 KB (0%)
@blocksuite/data-view 209.99 KB (0%)
@blocksuite/affine-model 30.03 KB (0%)
@blocksuite/affine-shared 24.28 KB (0%)
@blocksuite/blocks 3.49 MB (+0.01% 🔺)
@blocksuite/block-std 105.8 KB (0%)
@blocksuite/global 28.4 KB (0%)
@blocksuite/inline 23.76 KB (0%)
@blocksuite/store 64 KB (0%)
@blocksuite/sync 95.99 KB (0%)
@blocksuite/presets 200.68 KB (0%)

@fundon fundon added the dont merge Experimental pull requests label Sep 13, 2024 — with Graphite App
@fundon fundon force-pushed the fundon/09_13_fix_linked_and_synced_doc_loading_state branch from 0873d1e to 40f2c6b Compare September 13, 2024 12:12
@fundon fundon changed the title fix(blocks): linked and synced loading state on shared mode refactor(blocks): improve state initialization in EmbedLinkedDocBlockComponent Sep 13, 2024
@fundon fundon force-pushed the fundon/09_13_fix_linked_and_synced_doc_loading_state branch from 40f2c6b to 60b2757 Compare September 13, 2024 12:22
@fundon fundon removed the dont merge Experimental pull requests label Sep 13, 2024
@fundon fundon mentioned this pull request Sep 13, 2024
Merged
@fundon fundon force-pushed the fundon/09_13_fix_linked_and_synced_doc_loading_state branch from 60b2757 to 38d2bbf Compare September 13, 2024 12:35
Saul-Mirone
Saul-Mirone approved these changes Sep 13, 2024
View reviewed changes
Copy link
Collaborator

@Saul-Mirone Saul-Mirone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fundon fundon force-pushed the fundon/09_13_fix_linked_and_synced_doc_loading_state branch from 38d2bbf to e3219ea Compare September 13, 2024 12:47
@graphite-app Graphite App
Copy link

graphite-app bot commented Sep 13, 2024 •
edited
Loading

Merge activity

@fundon fundon force-pushed the fundon/09_13_fix_linked_and_synced_doc_loading_state branch from e3219ea to 9f1edb4 Compare September 13, 2024 12:52
@graphite-app graphite-app bot merged commit 9f1edb4 into master Sep 13, 2024
36 checks passed
@graphite-app graphite-app bot deleted the fundon/09_13_fix_linked_and_synced_doc_loading_state branch September 13, 2024 12:57
fundon added a commit to toeverything/AFFiNE that referenced this pull request Sep 19, 2024
@fundon
fix(core): override LinkedDocBlockComponent initial state (#8253)
bba9e79 
Upstreams: toeverything/blocksuite#8354

<div class='graphite__hidden'>
          <div>🎥 Video uploaded on Graphite:</div>
            <a href="https://app.graphite.dev/media/video/8ypiIKZXudF5a0tIgIzf/f8214c18-2fb7-4cbe-9d0d-5302f520b676.mov">
              <img src="https://app.graphite.dev/api/v1/graphite/video/thumbnail/8ypiIKZXudF5a0tIgIzf/f8214c18-2fb7-4cbe-9d0d-5302f520b676.mov">
            </a>
          </div>
<video src="https://graphite-user-uploaded-assets-prod.s3.amazonaws.com/8ypiIKZXudF5a0tIgIzf/f8214c18-2fb7-4cbe-9d0d-5302f520b676.mov">Screen Recording 2024-09-13 at 20.27.38.mov</video>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Saul-Mirone Saul-Mirone Saul-Mirone approved these changes

Assignees

@fundon fundon

Labels
None yet
Projects
BlockSuite Project
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fundon @Saul-Mirone