Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): override LinkedDocBlockComponent initial state #8253

Merged
merged 1 commit into from
Sep 19, 2024
Merged

fix(core): override LinkedDocBlockComponent initial state #8253

merged 1 commit into from
Sep 19, 2024

Conversation

fundon
Copy link
Contributor

@fundon fundon commented Sep 13, 2024 •
edited
Loading

Upstreams: toeverything/blocksuite#8354

🎥 Video uploaded on Graphite:

@graphite-app Graphite App
Copy link

graphite-app bot commented Sep 13, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@fundon Graphite App
Copy link
Contributor Author

fundon commented Sep 13, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @fundon and the rest of your teammates on Graphite Graphite

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Sep 13, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit bba9e79. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 6 targets

Sent with 💌 from NxCloud.

@fundon fundon marked this pull request as ready for review September 13, 2024 12:26
@codecov Codecov
Copy link

codecov bot commented Sep 13, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.71%. Comparing base (f4a1992) to head (bba9e79).
Report is 1 commits behind head on canary.

Additional details and impacted files 
@@           Coverage Diff           @@
##           canary    #8253   +/-   ##
=======================================
  Coverage   72.71%   72.71%           
=======================================
  Files         519      519           
  Lines       32797    32797           
  Branches     2973     2973           
=======================================
  Hits        23847    23847           
  Misses       8919     8919           
  Partials       31       31
Flag Coverage Δ
server-test 78.86% <ø> (ø)
unittest 49.72% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fundon fundon force-pushed the fundon/09_13_BS-1417 branch 2 times, most recently from 55448b9 to 9f59abf Compare September 13, 2024 12:57
@fundon fundon changed the base branch from canary to fundon/09_06_improve_scroll_anchoring September 13, 2024 12:57
@github-actions github-actions bot added the mod:i18n Related to i18n label Sep 13, 2024
This was referenced Sep 13, 2024
Merged
Merged
@fundon fundon force-pushed the fundon/09_13_BS-1417 branch 2 times, most recently from 042fc8e to be54a4c Compare September 13, 2024 13:02
@fundon fundon mentioned this pull request Sep 13, 2024
Merged
@fundon fundon changed the base branch from fundon/09_06_improve_scroll_anchoring to graphite-base/8253 September 13, 2024 13:13
@fundon fundon changed the base branch from graphite-base/8253 to canary September 13, 2024 13:25
@fundon fundon force-pushed the fundon/09_13_BS-1417 branch 2 times, most recently from b133262 to 1b97dc7 Compare September 14, 2024 22:46
@fundon fundon changed the title fix(core): linked and synced doc does not need to load in shared mode fix(core): override LinkedDocBlockComponent initial state Sep 18, 2024
@fundon fundon changed the base branch from canary to fundon/09_13_refactor_quick_search_and_slash_menu_extensions September 18, 2024 11:20
This was referenced Sep 18, 2024
Merged
Merged
Merged
@EYHN EYHN changed the base branch from fundon/09_13_refactor_quick_search_and_slash_menu_extensions to graphite-base/8253 September 18, 2024 12:11
@EYHN EYHN changed the base branch from graphite-base/8253 to canary September 18, 2024 12:24
@graphite-app Graphite App
Copy link

graphite-app bot commented Sep 19, 2024 •
edited
Loading

Merge activity

@graphite-app graphite-app bot merged commit bba9e79 into canary Sep 19, 2024
38 checks passed
@graphite-app graphite-app bot deleted the fundon/09_13_BS-1417 branch September 19, 2024 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@forehalo forehalo forehalo approved these changes

@pengx17 pengx17 Awaiting requested review from pengx17

@EYHN EYHN Awaiting requested review from EYHN

@CatsJuice CatsJuice Awaiting requested review from CatsJuice

@JimmFly JimmFly Awaiting requested review from JimmFly

Assignees
No one assigned
Labels
app:core mod:i18n Related to i18n
Projects
AFFiNE Project
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fundon @forehalo @akumatus