feat(core): add error notification for block not found #8254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 13, 2024
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Your org has enabled the Graphite merge queue for merging into canaryAdd the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 46f8237. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
graphite-app
bot
requested review from
EYHN,
pengx17,
JimmFly,
CatsJuice and
forehalo
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## canary #8254 +/- ##
==========================================
- Coverage 72.64% 72.62% -0.03%
==========================================
Files 519 519
Lines 32781 32781
Branches 2966 2965 -1
==========================================
- Hits 23815 23808 -7
- Misses 8929 8936 +7
Partials 37 37
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
pengx17
approved these changes
Sep 13, 2024
fundon
force-pushed
the
fundon/09_13_BS-1417
branch
2 times, most recently
from
97e0089
to
b133262
Compare
fundon
force-pushed
the
fundon/09_13_BS-1416
branch
from
d29dada
to
9d93721
Compare
fundon
force-pushed
the
fundon/09_13_BS-1417
branch
from
b133262
to
1b97dc7
Compare
fundon
force-pushed
the
fundon/09_13_BS-1416
branch
from
9d93721
to
b41a0a1
Compare
fundon
changed the title
fundon
force-pushed
the
fundon/09_13_BS-1416
branch
from
b41a0a1
to
baece9a
Compare
Merge activity
|
Closes [BS-1416](https://linear.app/affine-design/issue/BS-1416/被删除的白板或者-page-里的-block，访问其-link-to-block，跳转之后没有-toast-提示) <div class='graphite__hidden'> <div>🎥 Video uploaded on Graphite:</div> <a href="https://app.graphite.dev/media/video/8ypiIKZXudF5a0tIgIzf/76e0e8d8-8685-41a2-abc8-79b330854a7e.mov"> <img src="https://app.graphite.dev/api/v1/graphite/video/thumbnail/8ypiIKZXudF5a0tIgIzf/76e0e8d8-8685-41a2-abc8-79b330854a7e.mov"> </a> </div> <video src="https://graphite-user-uploaded-assets-prod.s3.amazonaws.com/8ypiIKZXudF5a0tIgIzf/76e0e8d8-8685-41a2-abc8-79b330854a7e.mov">Screen Recording 2024-09-13 at 21.09.20.mov</video>
fundon
force-pushed
the
fundon/09_13_BS-1416
branch
from
baece9a
to
46f8237
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes BS-1416