This repository was archived by the owner on Dec 16, 2022. It is now read-only.
update to latest and suppress vtgate logging#2
Merged
Conversation
Other changes: - Unexport methods which should not be used. - Remove unused method.
The flag defined in binlog is already defined in worker. No real binary includes both, but unit tests do.
And fixing bug it uncovered: propagating PK Type.
First version of a doc about API scope.
Rbr: support horizontal sharding, and update stream.
Better compare TabletStats in tests.
A stray trailing comma caused JSON parse errors in the test suite, which turned out to take a while to debug since the test output didn't flag the invalid JSON. Instead catch errors in JSON.compact and panic.
Initial keytar commit.
…rom_full_scan Removing the cap on the # of iterations of SplitQuery.
This will allow her to LGTM changes from Reviewable.io where we use the "-bot" account.
Making some topo code more readable.
proto: Add README.md to document our required style guide.
sqlparser: Remove accidentally committed test binary.
JDBC bugfix: Don't reuse a defunct databaseMetaData
Adds support for decoding bytes in metadata calls
vtctld UI: Push the recent UI change of workflow creation dialogue.
|
👍 |
guidoiaquinti
pushed a commit
that referenced
this pull request
Jun 13, 2017
demmer
pushed a commit
that referenced
this pull request
Jun 27, 2017
rafael
pushed a commit
that referenced
this pull request
Jan 12, 2018
rafael
pushed a commit
that referenced
this pull request
May 14, 2020
This is the 1st commit message: VDiff ad-hoc version for slack This is the commit message #2: Removes extra log items Signed-off-by: Rafael Chacon <rafael@slack-corp.com> This is the commit message #3: Print actual position where it actually stop Signed-off-by: Rafael Chacon <rafael@slack-corp.com> This is the commit message #4: Fixes bug in filepos flavor * Prior to this commit, flavorpos was using lexicographical comparison of the gtids. Thas was a bug in this context. Signed-off-by: Rafael Chacon <rafael@slack-corp.com> This is the commit message #5: Updates how master gtid position is obtained for file:pos flavor When generating masterGTIDSet in file:pos most likely you will have a topology like the following: Source A -> Target B (B has a vreplication stream from A) From the target perspective, the source A is the master and you want to generate a gtid that is based on binlog file position of that server. As an example, let's see this topology: Master A -> Source B -> Target C (C has vreplication stream from B) Prior to this change, masterGTIDSet was returning the binlogfile:pos of A. But in reality, the Target C wants the position of B. Signed-off-by: Rafael Chacon <rafael@slack-corp.com> This is the commit message #6: Cleanup per review * Address PR review + some other cleanup per linter Signed-off-by: Rafael Chacon <rafael@slack-corp.com>
rafael
pushed a commit
that referenced
this pull request
Aug 13, 2020
This is the 1st commit message: VDiff ad-hoc version for slack This is the commit message #2: Removes extra log items Signed-off-by: Rafael Chacon <rafael@slack-corp.com> This is the commit message #3: Print actual position where it actually stop Signed-off-by: Rafael Chacon <rafael@slack-corp.com> This is the commit message #4: Fixes bug in filepos flavor * Prior to this commit, flavorpos was using lexicographical comparison of the gtids. Thas was a bug in this context. Signed-off-by: Rafael Chacon <rafael@slack-corp.com> This is the commit message #5: Updates how master gtid position is obtained for file:pos flavor When generating masterGTIDSet in file:pos most likely you will have a topology like the following: Source A -> Target B (B has a vreplication stream from A) From the target perspective, the source A is the master and you want to generate a gtid that is based on binlog file position of that server. As an example, let's see this topology: Master A -> Source B -> Target C (C has vreplication stream from B) Prior to this change, masterGTIDSet was returning the binlogfile:pos of A. But in reality, the Target C wants the position of B. Signed-off-by: Rafael Chacon <rafael@slack-corp.com> This is the commit message #6: Cleanup per review * Address PR review + some other cleanup per linter Signed-off-by: Rafael Chacon <rafael@slack-corp.com>
rafael
pushed a commit
that referenced
this pull request
Oct 1, 2020
This is the 1st commit message: VDiff ad-hoc version for slack This is the commit message #2: Removes extra log items Signed-off-by: Rafael Chacon <rafael@slack-corp.com> This is the commit message #3: Print actual position where it actually stop Signed-off-by: Rafael Chacon <rafael@slack-corp.com> This is the commit message #4: Fixes bug in filepos flavor * Prior to this commit, flavorpos was using lexicographical comparison of the gtids. Thas was a bug in this context. Signed-off-by: Rafael Chacon <rafael@slack-corp.com> This is the commit message #5: Updates how master gtid position is obtained for file:pos flavor When generating masterGTIDSet in file:pos most likely you will have a topology like the following: Source A -> Target B (B has a vreplication stream from A) From the target perspective, the source A is the master and you want to generate a gtid that is based on binlog file position of that server. As an example, let's see this topology: Master A -> Source B -> Target C (C has vreplication stream from B) Prior to this change, masterGTIDSet was returning the binlogfile:pos of A. But in reality, the Target C wants the position of B. Signed-off-by: Rafael Chacon <rafael@slack-corp.com> This is the commit message #6: Cleanup per review * Address PR review + some other cleanup per linter Signed-off-by: Rafael Chacon <rafael@slack-corp.com> Fixes due to changes upstream Fixes due to bad cherry-pick Fixes due to refactors upstream Signed-off-by: Rafael Chacon <rafael@slack-corp.com> one more bad merge Slowly building context around this code from december again Refactor to use new name Signed-off-by: Rafael Chacon <rafael@slack-corp.com>
rafael
pushed a commit
that referenced
this pull request
Oct 7, 2020
This is the 1st commit message: VDiff ad-hoc version for slack This is the commit message #2: Removes extra log items Signed-off-by: Rafael Chacon <rafael@slack-corp.com> This is the commit message #3: Print actual position where it actually stop Signed-off-by: Rafael Chacon <rafael@slack-corp.com> This is the commit message #4: Fixes bug in filepos flavor * Prior to this commit, flavorpos was using lexicographical comparison of the gtids. Thas was a bug in this context. Signed-off-by: Rafael Chacon <rafael@slack-corp.com> This is the commit message #5: Updates how master gtid position is obtained for file:pos flavor When generating masterGTIDSet in file:pos most likely you will have a topology like the following: Source A -> Target B (B has a vreplication stream from A) From the target perspective, the source A is the master and you want to generate a gtid that is based on binlog file position of that server. As an example, let's see this topology: Master A -> Source B -> Target C (C has vreplication stream from B) Prior to this change, masterGTIDSet was returning the binlogfile:pos of A. But in reality, the Target C wants the position of B. Signed-off-by: Rafael Chacon <rafael@slack-corp.com> This is the commit message #6: Cleanup per review * Address PR review + some other cleanup per linter Signed-off-by: Rafael Chacon <rafael@slack-corp.com> Fixes due to changes upstream Fixes due to bad cherry-pick Fixes due to refactors upstream Signed-off-by: Rafael Chacon <rafael@slack-corp.com> one more bad merge Slowly building context around this code from december again Refactor to use new name Signed-off-by: Rafael Chacon <rafael@slack-corp.com>
rafael
pushed a commit
that referenced
this pull request
May 18, 2021
…ion/cancellation This is a combination of 4 commits. This is the commit message #2: Check that routing rules are deleted in unit test This is the commit message #3: Fix typo This is the commit message #4: Refresh all tablets in a shard when updating blacklisted tables Signed-off-by: Rohit Nayak <rohit@planetscale.com> Signed-off-by: Andres Taylor <andres@planetscale.com>
pbibra
pushed a commit
that referenced
this pull request
Jul 20, 2022
* Implement VDiff2 delete command Also add --verbose flag for VDiff output Signed-off-by: Matt Lord <mattalord@gmail.com> * Delete vdiff metadata associated with a deleted workflow Signed-off-by: Matt Lord <mattalord@gmail.com> * Tweaks after self review Signed-off-by: Matt Lord <mattalord@gmail.com> * Self review #2 Signed-off-by: Matt Lord <mattalord@gmail.com> * Spelling is herd Signed-off-by: Matt Lord <mattalord@gmail.com> * Add test for vdiff data cleanup on workflow deletion Signed-off-by: Matt Lord <mattalord@gmail.com> * Caught mistake on self-review #3 Signed-off-by: Matt Lord <mattalord@gmail.com> * Add a couple more delete tests Signed-off-by: Matt Lord <mattalord@gmail.com> * Clear out vdiff_log table as well on workflow deletion Signed-off-by: Matt Lord <mattalord@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the slack fork to the latest master as of 2017-03-26 (6842fe3).
Add a quick and dirty patch to suppress verbose vtgate logging of queries.