First version of a doc about API scope.#2642
Merged
alainjobart merged 1 commit intovitessio:masterfrom Mar 20, 2017
Merged
Conversation
sougou
approved these changes
Mar 17, 2017
Contributor
sougou
left a comment
There was a problem hiding this comment.
Looks like it covers everything we discussed. The scope of a shard query is still being debated. I can add the details once that's finalized.
doc/APIScope.md
Outdated
Contributor
There was a problem hiding this comment.
The 0 shard is a special case which will always create confusion. Hence I suggest to better call it out e.g.
For unsharded keyspaces, or custom sharded keyspaces, the shard names have traditionally been numbers e.g.
0. (It is important to note that Vitess does not interpret these shards (including shard name0) as range-based shard.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@sougou first draft, let's talk about it, or you can comment.