Skip to content
This repository was archived by the owner on Dec 16, 2022. It is now read-only.
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
101 commits
Select commit Hold shift + click to select a range
0fc2280
Initial keytar commit.
thompsonja Feb 15, 2017
901ff3b
Address comments
thompsonja Mar 2, 2017
f0cfb9b
Address comments.
thompsonja Mar 7, 2017
36cfeba
Address comments.
thompsonja Mar 8, 2017
baeac3f
Simplify vitess_config.yaml to minimum steps needed to run tests.
thompsonja Mar 8, 2017
db54b8c
Add check for default cloud project.
thompsonja Mar 9, 2017
a939417
Adding horizontal resharding rbr test.
alainjobart Mar 16, 2017
e9a2ba9
Fixing import section.
alainjobart Mar 16, 2017
ffddbd1
Add RBR resolvers for horizontal resharding.
alainjobart Mar 16, 2017
6e60abd
sync2: Consolidator: Add documentation for ccount.
michael-berlin Mar 1, 2017
e3caf2f
Add comments and other minor refactors.
thompsonja Mar 9, 2017
cfbaafc
Adding update stream support for RBR.
alainjobart Mar 17, 2017
1f0d311
Fixing unit tests.
alainjobart Mar 17, 2017
910aa98
Adding update_stream integration test for RBR.
alainjobart Mar 17, 2017
d4a334f
Refactoring use_rbr flag in tests.
alainjobart Mar 17, 2017
6fa0db7
First version of a doc about API scope.
alainjobart Mar 17, 2017
7293a02
Merge pull request #2642 from alainjobart/doc
alainjobart Mar 20, 2017
c1b7344
Merge pull request #2640 from alainjobart/rbr
alainjobart Mar 20, 2017
748e938
Better compare TabletStats in tests.
alainjobart Mar 20, 2017
a71cb38
Merge pull request #2649 from alainjobart/equal
alainjobart Mar 20, 2017
65c10cd
Address readability comments.
thompsonja Mar 20, 2017
d0d8321
panic if a planbuilder test input contains invalid JSON (#2648)
demmer Mar 20, 2017
2cf506d
Address readability comments
thompsonja Mar 21, 2017
fe50f2c
Address readability comments.
thompsonja Mar 21, 2017
14a8263
Merge pull request #2582 from thompsonja/cluster_test
thompsonja Mar 21, 2017
cc4ab78
Removing the cap on the # of iterations of SplitQuery.
erzel Mar 21, 2017
f8e99a6
Merge pull request #2651 from erzel/removing_max_iterations_from_full…
erzel Mar 22, 2017
25ead16
change iff to if (#2653)
davygeek Mar 22, 2017
3f844cf
Add Yipei's bot account as approver.
michael-berlin Mar 22, 2017
fae4a67
planbuilder: unit test: Explicitly log "got" and "want".
michael-berlin Mar 22, 2017
2c2fa7c
vttablet: Hot Row protection for Transaction Pool.
michael-berlin Mar 1, 2017
0106eac
vttablet: Remove usage of exit.Return().
michael-berlin Mar 15, 2017
3f74b73
planbuilder: Do not add method "MarshalJSON" to "Plan" struct in unit…
michael-berlin Mar 22, 2017
50e7811
py/vttest: Remove unused import.
michael-berlin Mar 22, 2017
cbd4846
Merge pull request #2609 from michael-berlin/tx_consolidator
michael-berlin Mar 22, 2017
01e39f2
Merge pull request #2656 from michael-berlin/mysql_flavor_fix
michael-berlin Mar 22, 2017
515bd47
Getting to the bottom of the 2006/2013 mystery.
alainjobart Mar 22, 2017
1ffb60d
Merge pull request #2658 from alainjobart/mysqlconn
alainjobart Mar 22, 2017
1aea402
add parser support for SHOW (DATABASES | TABLES | VITESS_SHARDS)
demmer Mar 19, 2017
37574bd
add preliminary vtgate support for show commands
demmer Mar 20, 2017
72663dc
update the grammar to properly handle SHOW <anything>
demmer Mar 20, 2017
ff0d3af
pass through Show statements in vttablet
demmer Mar 20, 2017
7f5e90e
rename the route and associated handlers to "Show" from "Metadata"
demmer Mar 20, 2017
232de4c
use keyspace/shard as the convention in `show vitess_shards`
demmer Mar 20, 2017
1273744
add support for `show tables` to list the known tables in the vschema
demmer Mar 21, 2017
7f0d025
add parser support for `show vitess_keyspaces` and `show vschema_tables`
demmer Mar 21, 2017
475062e
add vtgate support for `show vitess_keyspaces` `show vschema_tables`
demmer Mar 21, 2017
a2365df
fix unit test for show cases
demmer Mar 21, 2017
bd8e5ed
remove dead code caught in PR review
demmer Mar 21, 2017
fdcc007
add a couple test cases for error conditions
demmer Mar 22, 2017
69b53d1
Adding RBR test, fixing RBR timestamp.
alainjobart Mar 20, 2017
ba3e63e
Adding tests for more types.
alainjobart Mar 20, 2017
a850b6b
Adding test cases for rest of types.
alainjobart Mar 21, 2017
5504182
Fixing unit tests in RBR.
alainjobart Mar 21, 2017
a1e2f3d
Fixing time zone for RBR events.
alainjobart Mar 21, 2017
035aa5a
Setting time zone in test.
alainjobart Mar 21, 2017
31de99c
Fixing mariaDB and MySQL 5.7 RBR code.
alainjobart Mar 21, 2017
bed46a1
Fixing clear text auth test on MariaDB.
alainjobart Mar 21, 2017
022100c
Fixing timezone handling in RBR test.
alainjobart Mar 22, 2017
8c8f5b0
Fixing timestamp handling in binlogs.
alainjobart Mar 22, 2017
5d52636
Couple docs.
alainjobart Mar 22, 2017
0c4aaca
Merge pull request #2659 from alainjobart/doc
alainjobart Mar 22, 2017
5a3e23a
Adds support for decoding bytes in metadata calls
bbeaudreault Feb 28, 2017
a8fc185
add a test to ensure proper class type of getObject
bbeaudreault Mar 19, 2017
7bde448
limit scope of passed Connection to just ConnectionProperties. Move s…
bbeaudreault Mar 20, 2017
e5d1cc8
change here too
bbeaudreault Mar 20, 2017
eebd543
Don't reuse a defunct databaseMetaData
bbeaudreault Mar 23, 2017
81821b3
Merge pull request #2655 from michael-berlin/plan_test
michael-berlin Mar 23, 2017
cec080c
Merge pull request #2657 from michael-berlin/fix_json_marshal
michael-berlin Mar 23, 2017
087d429
Addressing review comments: using fmt.Fprintf.
alainjobart Mar 23, 2017
76c0ab2
Addressing comments in these docs.
alainjobart Mar 23, 2017
de406f2
Merge pull request #2661 from alainjobart/doc
alainjobart Mar 23, 2017
e7f2af8
Merge pull request #2650 from alainjobart/rbr
alainjobart Mar 23, 2017
cadc5ce
worker: Fix throttler panic when SplitClone fails.
michael-berlin Mar 23, 2017
8202c5a
worker: Cancel context after test execution is done.
michael-berlin Mar 23, 2017
46c16a8
Merge pull request #2662 from michael-berlin/vtworker_fix
michael-berlin Mar 23, 2017
0f58c4f
Making some topo code more readable.
alainjobart Mar 23, 2017
be7f12f
proto: Add README.md to document our required style guide.
michael-berlin Mar 23, 2017
61d4a2e
Merge pull request #2654 from michael-berlin/add_bot
michael-berlin Mar 23, 2017
5aa4c04
mysqlconn: add authServerNone for easier testing
sougou Mar 18, 2017
803ec65
v3: support keyspace:shard in request
sougou Mar 19, 2017
1403c14
v3: Execute handles transaction statements
sougou Mar 20, 2017
5dedb90
v3: autocommit support
sougou Mar 21, 2017
021fbe0
v3 keyrange: proto keyspace->keyspace_shard
sougou Mar 21, 2017
61b190c
v3 keyrange: address code review comments
sougou Mar 21, 2017
5ffd9d5
v3 keyrange: address more review comments
sougou Mar 21, 2017
72dec1e
v3 keyrange: keyspace/shard format
sougou Mar 21, 2017
b78c9ed
v3 keyrange: more review comments.
sougou Mar 22, 2017
783fed1
Merge pull request #2664 from alainjobart/topo
alainjobart Mar 23, 2017
eaa5cff
Merge pull request #2663 from michael-berlin/protobuf_readme
michael-berlin Mar 23, 2017
2e2b206
sqlparser: Remove accidentally committed test binary.
michael-berlin Mar 23, 2017
b6936ae
Merge pull request #2666 from michael-berlin/remove_test_binary
michael-berlin Mar 23, 2017
8dfbc3f
Support fulltext and spatial indexes in DDL language (#2665)
bbeaudreault Mar 23, 2017
0d01bb7
vttablet endtoend: deflake message_test (#2667)
sougou Mar 23, 2017
240b884
Rename to Closed
bbeaudreault Mar 24, 2017
d6b9a38
Merge pull request #2660 from HubSpot/defunct_metadata
michael-berlin Mar 24, 2017
5481e45
Merge pull request #2645 from HubSpot/fix_metadata_decoding
michael-berlin Mar 24, 2017
1537907
v3: normalize_queries defaults to true
sougou Mar 24, 2017
a845e45
vtctld UI: Push the recent UI change of workflow creation dialogue.
wangyipei01 Mar 24, 2017
6842fe3
Merge pull request #2676 from wangyipei01/deployUI
wangyipei01 Mar 24, 2017
449ea49
remove verbose command and connection logging
demmer Mar 26, 2017
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .pullapprove.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,4 +28,5 @@ groups:
- pivanof
- pivanof-bot
- wangyipei01
- wangyipei01-bot

81 changes: 54 additions & 27 deletions data/test/tabletserver/exec_cases.txt
Original file line number Diff line number Diff line change
Expand Up @@ -578,7 +578,8 @@
"FullQuery": "update b set eid = 1",
"OuterQuery": "update b set eid = 1 where :#pk",
"Subquery": "select eid, id from b limit :#maxLimit for update",
"SecondaryPKValues": [1, null]
"SecondaryPKValues": [1, null],
"WhereClause": ""
}

# type mismatch
Expand All @@ -591,7 +592,8 @@
"PlanID": "PASS_DML",
"Reason": "PK_CHANGE",
"TableName": "b",
"FullQuery": "update b set eid = foo()"
"FullQuery": "update b set eid = foo()",
"WhereClause": ""
}

# update subquery
Expand All @@ -601,7 +603,8 @@
"TableName": "a",
"FullQuery": "update a set name = 'foo'",
"OuterQuery": "update a set name = 'foo' where :#pk",
"Subquery": "select eid, id from a limit :#maxLimit for update"
"Subquery": "select eid, id from a limit :#maxLimit for update",
"WhereClause": ""
}

# update complex where clause
Expand All @@ -611,7 +614,8 @@
"TableName": "a",
"FullQuery": "update a set name = 'foo' where eid + 1 = 1",
"OuterQuery": "update a set name = 'foo' where :#pk",
"Subquery": "select eid, id from a where eid + 1 = 1 limit :#maxLimit for update"
"Subquery": "select eid, id from a where eid + 1 = 1 limit :#maxLimit for update",
"WhereClause": " where eid + 1 = 1"
}

# pk
Expand All @@ -621,7 +625,8 @@
"TableName": "a",
"FullQuery": "update a set name = 'foo' where eid = 1 and id = 1",
"OuterQuery": "update a set name = 'foo' where :#pk",
"PKValues": [1, 1]
"PKValues": [1, 1],
"WhereClause": " where eid = 1 and id = 1"
}

# partial pk
Expand All @@ -631,7 +636,8 @@
"TableName": "a",
"FullQuery": "update a set name = 'foo' where eid = 1",
"OuterQuery": "update a set name = 'foo' where :#pk",
"Subquery": "select eid, id from a where eid = 1 limit :#maxLimit for update"
"Subquery": "select eid, id from a where eid = 1 limit :#maxLimit for update",
"WhereClause": " where eid = 1"
}

# bad pk
Expand All @@ -641,7 +647,8 @@
"TableName": "a",
"FullQuery": "update a set name = 'foo' where eid = 1.0 and id = 1",
"OuterQuery": "update a set name = 'foo' where :#pk",
"Subquery": "select eid, id from a where eid = 1.0 and id = 1 limit :#maxLimit for update"
"Subquery": "select eid, id from a where eid = 1.0 and id = 1 limit :#maxLimit for update",
"WhereClause": " where eid = 1.0 and id = 1"
}

# partial pk with limit
Expand All @@ -651,7 +658,8 @@
"TableName": "a",
"FullQuery": "update a set name = 'foo' where eid = 1 limit 10",
"OuterQuery": "update a set name = 'foo' where :#pk",
"Subquery": "select eid, id from a where eid = 1 limit 10 for update"
"Subquery": "select eid, id from a where eid = 1 limit 10 for update",
"WhereClause": " where eid = 1"
}

# non-pk
Expand All @@ -661,7 +669,8 @@
"TableName": "a",
"FullQuery": "update a set name = 'foo' where eid = 1 and name = 'foo'",
"OuterQuery": "update a set name = 'foo' where :#pk",
"Subquery": "select eid, id from a where eid = 1 and name = 'foo' limit :#maxLimit for update"
"Subquery": "select eid, id from a where eid = 1 and name = 'foo' limit :#maxLimit for update",
"WhereClause": " where eid = 1 and name = 'foo'"
}

# no index
Expand All @@ -670,7 +679,8 @@
"PlanID": "PASS_DML",
"Reason": "TABLE_NOINDEX",
"TableName": "c",
"FullQuery": "update c set eid = 1"
"FullQuery": "update c set eid = 1",
"WhereClause": ""
}

# complex expression in where
Expand All @@ -680,7 +690,8 @@
"TableName":"a",
"FullQuery":"update a set name = 'foo' where eid + 1 = 1 and id = 1",
"OuterQuery":"update a set name = 'foo' where :#pk",
"Subquery":"select eid, id from a where eid + 1 = 1 and id = 1 limit :#maxLimit for update"
"Subquery":"select eid, id from a where eid + 1 = 1 and id = 1 limit :#maxLimit for update",
"WhereClause": " where eid + 1 = 1 and id = 1"
}

# parenthesized expressions in where
Expand All @@ -690,7 +701,8 @@
"TableName": "a",
"FullQuery": "update a set name = 'foo' where (eid = 1) and id = 1",
"OuterQuery": "update a set name = 'foo' where :#pk",
"PKValues": [1, 1]
"PKValues": [1, 1],
"WhereClause": " where (eid = 1) and id = 1"
}

# in clause expression in where
Expand All @@ -700,7 +712,8 @@
"TableName":"a",
"FullQuery":"update a set name = 'foo' where eid in (1, 2) and id = 1",
"OuterQuery":"update a set name = 'foo' where :#pk",
"PKValues":[[1,2],1]
"PKValues":[[1,2],1],
"WhereClause": " where eid in (1, 2) and id = 1"
}

# double in clause
Expand All @@ -710,7 +723,8 @@
"TableName":"a",
"FullQuery":"update a set name = 'foo' where eid in (1, 2) and id in (1, 2)",
"OuterQuery":"update a set name = 'foo' where :#pk",
"Subquery":"select eid, id from a where eid in (1, 2) and id in (1, 2) limit :#maxLimit for update"
"Subquery":"select eid, id from a where eid in (1, 2) and id in (1, 2) limit :#maxLimit for update",
"WhereClause": " where eid in (1, 2) and id in (1, 2)"
}

# double use of pk
Expand All @@ -720,7 +734,8 @@
"TableName":"a",
"FullQuery":"update a set name = 'foo' where eid = 1 and eid = 2",
"OuterQuery":"update a set name = 'foo' where :#pk",
"Subquery":"select eid, id from a where eid = 1 and eid = 2 limit :#maxLimit for update"
"Subquery":"select eid, id from a where eid = 1 and eid = 2 limit :#maxLimit for update",
"WhereClause": " where eid = 1 and eid = 2"
}

# delete cross-db
Expand All @@ -739,7 +754,8 @@
"TableName": "a",
"FullQuery": "delete from a",
"OuterQuery": "delete from a where :#pk",
"Subquery": "select eid, id from a limit :#maxLimit for update"
"Subquery": "select eid, id from a limit :#maxLimit for update",
"WhereClause": ""
}

# delete complex where clause
Expand All @@ -749,7 +765,8 @@
"TableName": "a",
"FullQuery": "delete from a where eid + 1 = 1",
"OuterQuery": "delete from a where :#pk",
"Subquery": "select eid, id from a where eid + 1 = 1 limit :#maxLimit for update"
"Subquery": "select eid, id from a where eid + 1 = 1 limit :#maxLimit for update",
"WhereClause": " where eid + 1 = 1"
}

# pk
Expand All @@ -759,7 +776,8 @@
"TableName": "a",
"FullQuery": "delete from a where eid = 1 and id = 1",
"OuterQuery": "delete from a where :#pk",
"PKValues": [1, 1]
"PKValues": [1, 1],
"WhereClause": " where eid = 1 and id = 1"
}

# partial pk
Expand All @@ -769,7 +787,8 @@
"TableName": "a",
"FullQuery": "delete from a where eid = 1",
"OuterQuery": "delete from a where :#pk",
"Subquery": "select eid, id from a where eid = 1 limit :#maxLimit for update"
"Subquery": "select eid, id from a where eid = 1 limit :#maxLimit for update",
"WhereClause": " where eid = 1"
}

# bad pk value delete
Expand All @@ -779,7 +798,8 @@
"TableName": "a",
"FullQuery": "delete from a where eid = 1.0 and id = 1",
"OuterQuery": "delete from a where :#pk",
"Subquery": "select eid, id from a where eid = 1.0 and id = 1 limit :#maxLimit for update"
"Subquery": "select eid, id from a where eid = 1.0 and id = 1 limit :#maxLimit for update",
"WhereClause": " where eid = 1.0 and id = 1"
}

# non-pk
Expand All @@ -789,7 +809,8 @@
"TableName": "a",
"FullQuery": "delete from a where eid = 1 and name = 'foo'",
"OuterQuery": "delete from a where :#pk",
"Subquery": "select eid, id from a where eid = 1 and name = 'foo' limit :#maxLimit for update"
"Subquery": "select eid, id from a where eid = 1 and name = 'foo' limit :#maxLimit for update",
"WhereClause": " where eid = 1 and name = 'foo'"
}

# no index
Expand All @@ -798,7 +819,8 @@
"PlanID": "PASS_DML",
"Reason": "TABLE_NOINDEX",
"TableName": "c",
"FullQuery": "delete from c"
"FullQuery": "delete from c",
"WhereClause": ""
}

# delete complex expression in where
Expand All @@ -808,7 +830,8 @@
"TableName":"a",
"FullQuery":"delete from a where eid + 1 = 1 and id = 1",
"OuterQuery":"delete from a where :#pk",
"Subquery":"select eid, id from a where eid + 1 = 1 and id = 1 limit :#maxLimit for update"
"Subquery":"select eid, id from a where eid + 1 = 1 and id = 1 limit :#maxLimit for update",
"WhereClause": " where eid + 1 = 1 and id = 1"
}

# parenthesized expressions in where
Expand All @@ -818,7 +841,8 @@
"TableName": "a",
"FullQuery": "delete from a where (eid = 1) and id = 1",
"OuterQuery": "delete from a where :#pk",
"PKValues": [1, 1]
"PKValues": [1, 1],
"WhereClause": " where (eid = 1) and id = 1"
}

# delete in clause expression in where
Expand All @@ -828,7 +852,8 @@
"TableName":"a",
"FullQuery":"delete from a where eid in (1, 2) and id = 1",
"OuterQuery":"delete from a where :#pk",
"PKValues":[[1,2],1]
"PKValues":[[1,2],1],
"WhereClause": " where eid in (1, 2) and id = 1"
}

# delete double in clause
Expand All @@ -838,7 +863,8 @@
"TableName":"a",
"FullQuery":"delete from a where eid in (1, 2) and id in (1, 2)",
"OuterQuery":"delete from a where :#pk",
"Subquery":"select eid, id from a where eid in (1, 2) and id in (1, 2) limit :#maxLimit for update"
"Subquery":"select eid, id from a where eid in (1, 2) and id in (1, 2) limit :#maxLimit for update",
"WhereClause": " where eid in (1, 2) and id in (1, 2)"
}

# delete double use of pk
Expand All @@ -848,7 +874,8 @@
"TableName":"a",
"FullQuery":"delete from a where eid = 1 and eid = 2",
"OuterQuery":"delete from a where :#pk",
"Subquery":"select eid, id from a where eid = 1 and eid = 2 limit :#maxLimit for update"
"Subquery":"select eid, id from a where eid = 1 and eid = 2 limit :#maxLimit for update",
"WhereClause": " where eid = 1 and eid = 2"
}

# single value sequence
Expand Down
53 changes: 53 additions & 0 deletions data/test/vtgate/show_cases.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,53 @@
# unsupported show
"show create database"
"unsupported show statement"

# show databases
"show databases"
{
"Original": "show databases",
"Instructions": {
"Opcode": "Metadata",
"Query": "show databases"
}
}

# show tables
"show tables"
{
"Original": "show tables",
"Instructions": {
"Opcode": "Metadata",
"Query": "show tables"
}
}

# show vitess_keyspaces
"show vitess_keyspaces"
{
"Original": "show vitess_keyspaces",
"Instructions": {
"Opcode": "Metadata",
"Query": "show vitess_keyspaces"
}
}

# show vitess_shards
"show vitess_shards"
{
"Original": "show vitess_shards",
"Instructions": {
"Opcode": "Metadata",
"Query": "show vitess_shards"
}
}

# show vschema_tables
"show vschema_tables"
{
"Original": "show vschema_tables",
"Instructions": {
"Opcode": "Metadata",
"Query": "show vschema_tables"
}
}
Loading