Skip to content

Add a preference for enabling struct revision#1008

Merged
timholy merged 2 commits intotimholy:masterfrom
JamesWrigley:preference
Feb 24, 2026
Merged

Add a preference for enabling struct revision#1008
timholy merged 2 commits intotimholy:masterfrom
JamesWrigley:preference

Conversation

@JamesWrigley
Copy link
Contributor

@JamesWrigley JamesWrigley commented Feb 11, 2026

This disables it by default since the overhead is quite high. It's a slightly more invasive alternative to #992. Also fixed some links in 8a93737.

BTW since this doesn't really need to be a compile-time preference I would like to use this PR in the future once it's merged and released: JuliaPackaging/Preferences.jl#90.

Made with help from Claude 🤖

@JamesWrigley
Copy link
Contributor Author

(bump)

This disables it by default since the overhead is quite high.
@JamesWrigley
Copy link
Contributor Author

Bump, rebased to fix merge conflicts.

Copy link
Collaborator

@pfitzseb pfitzseb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Let's merge unless @timholy or @aviatesk have complaints about this, imho

@timholy timholy merged commit 79eb777 into timholy:master Feb 24, 2026
11 of 13 checks passed
@timholy
Copy link
Owner

timholy commented Feb 24, 2026

Thanks for doing this!

@timholy
Copy link
Owner

timholy commented Feb 24, 2026

I'll fix it so that the tests run with __bpart__[] = true

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants