test: ensure struct revision tests run on CI and test the preference mechanism#1012
Merged
test: ensure struct revision tests run on CI and test the preference mechanism#1012
Conversation
…mechanism The revise_structs preference defaults to false, so all struct revision tests were silently skipped on CI. Fix by forcing __bpart__[] = true before those tests on supported Julia versions. Add subprocess-based tests for the LocalPreferences mechanism, since the preference is read in __init__ and cannot be tested within the same process. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Owner
Author
|
CC @JamesWrigley (xref #1008) |
Contributor
|
Oops thanks, didn't realize that. The nightly failure looks new, I'm guessing something changed in Julia? On #1008 nightly did pass. |
Owner
Author
|
It seems the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The revise_structs preference defaults to false, so all struct revision tests were silently skipped on CI. Fix by forcing
__bpart__[] = truebefore those tests on supported Julia versions.Add subprocess-based tests for the LocalPreferences mechanism, since the preference is read in init and cannot be tested within the same process.
Co-Authored-By: Claude Sonnet 4.6 noreply@anthropic.com